Skip to content

feat: sanitise client fields for resource_server app type#1164

Merged
kushalshit27 merged 1 commit intomasterfrom
DXCDT-1224-token-vault-support-improvement
Sep 16, 2025
Merged

feat: sanitise client fields for resource_server app type#1164
kushalshit27 merged 1 commit intomasterfrom
DXCDT-1224-token-vault-support-improvement

Conversation

@kushalshit27
Copy link
Copy Markdown
Contributor

@kushalshit27 kushalshit27 commented Sep 16, 2025

🔧 Changes

sanitisation step for client objects to ensure that certain fields are removed from clients of the resource_server app type before processing changes. This helps prevent inappropriate fields from being included for resource server clients.

📚 References

🔬 Testing

  • Unit test pass ✅

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

- src/tools/auth0/handlers/clients.ts: Add sanitizeClientFields function to remove specific fields from resource_server type
- src/tools/auth0/handlers/clients.ts: Apply sanitizeClientFields to changes before processing
@kushalshit27 kushalshit27 changed the title feat: Sanitize client fields for resource_server app type feat: sanitise client fields for resource_server app type Sep 16, 2025
@kushalshit27 kushalshit27 marked this pull request as ready for review September 16, 2025 06:35
@kushalshit27 kushalshit27 requested a review from a team as a code owner September 16, 2025 06:35
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.15%. Comparing base (1edcd17) to head (ad9e49d).
⚠️ Report is 94 commits behind head on master.

Files with missing lines Patch % Lines
src/tools/auth0/handlers/clients.ts 40.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
- Coverage   80.24%   80.15%   -0.09%     
==========================================
  Files         131      131              
  Lines        5000     5010      +10     
  Branches      990      994       +4     
==========================================
+ Hits         4012     4016       +4     
- Misses        571      574       +3     
- Partials      417      420       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kushalshit27 kushalshit27 merged commit 6df534e into master Sep 16, 2025
7 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-1224-token-vault-support-improvement branch September 16, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants