Merged
Conversation
…rom 'auth0-server-js'
…lve merge conflicts and align MCD typing/build behavior
336f3c6 to
1726b95
Compare
ankita10119
approved these changes
Apr 9, 2026
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Multiple Custom Domains (MCD) support to
@auth0/auth0-fastifyby delegating issuer/domain resolution and validation to@auth0/auth0-server-jsand enabling request‑inferredappBaseUrlwhen using a resolver. Updates documentation and tests to cover inference behavior and risk guidance.Changes
domaincan now be aDomainResolver(from@auth0/auth0-server-js). ExposesDomainResolverandDomainResolverContextfrom this SDK for consumers.appBaseUrlremains required (same asmain).appBaseUrlis optional; if omitted, it’s inferred fromHost/x-forwarded-*.appBaseUrlis inferred,redirect_uriis passed per request; when static, a single redirect URI is precomputed.Usage example
Risks
appBaseUrlrelies on trusted proxy headers. IfHost/x-forwarded-*are not validated at the edge, redirects/logouts can be influenced. Mitigate by providing a staticappBaseUrlor enforcing header validation in the proxy.mainfor static domain usage; resolver mode is additive.Expecting pipeline failure
@auth0/auth0-server-jsis published, because this branch currently depends on a local path (or a version not yet available on npm).