[SDK-3508] Fix Integration Test CI for Android#282
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
=========================================
Coverage 96.08% 96.08%
Complexity 86 86
=========================================
Files 97 97
Lines 1611 1611
Branches 331 331
=========================================
Hits 1548 1548
Misses 49 49
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Widcket
reviewed
Jul 11, 2023
Widcket
reviewed
Jul 11, 2023
Widcket
reviewed
Jul 11, 2023
Widcket
reviewed
Jul 11, 2023
Widcket
reviewed
Jul 11, 2023
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Widcket
reviewed
Jul 11, 2023
Widcket
requested changes
Jul 11, 2023
Widcket
left a comment
Widcket
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much for fixing this!
Just a couple things:
- Let's stick, if possible, to the Circle CI Flutter Orb unless absolutely necessary.
- Let's try to avoid hardcoded absolute paths whenever possible.
Contributor
Author
|
Hey @Widcket, Great review. I have updated both the concerns and they should GTG now. |
Widcket
reviewed
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
We have fixed the CI for Android Integration test in this PR.
hintsthat has been provided Appium Inspector as resource-id is not present in classic UL where as new UL has them.📎 References
http://appium.io/docs/en/2.0/
https://discuss.circleci.com/t/failed-to-run-python-script-directly-pyenv-version-name-command-not-found/37526/2
https://github.com/CircleCI-Public/flutter-orb/blob/main/src/scripts/install-sdk.sh#L21
🎯 Testing
This PR adds integration tests