Improved OIDC compliance#43
Merged
lbalmaceda merged 31 commits intomasterfrom Oct 29, 2019
Merged
Conversation
joshcanhelp
reviewed
Oct 23, 2019
Contributor
joshcanhelp
left a comment
joshcanhelp
left a comment
There was a problem hiding this comment.
Adding as a comment so I'm not a blocker. Feel free to resolve any questions I'm asking that are handled (no need for an explanation, I'll assume "yes, that's fine").
In general, I would suggest moving anything in the RequestProcessor that's not specific to the ID token validation into a new PR.
Co-Authored-By: Josh Cunningham <josh.cunningham@auth0.com>
Co-Authored-By: Josh Cunningham <josh.cunningham@auth0.com>
lbalmaceda
commented
Oct 25, 2019
Co-Authored-By: Josh Cunningham <josh.cunningham@auth0.com>
Co-Authored-By: Josh Cunningham <josh.cunningham@auth0.com>
Co-Authored-By: Josh Cunningham <josh.cunningham@auth0.com>
Co-Authored-By: Josh Cunningham <josh.cunningham@auth0.com>
joshcanhelp
reviewed
Oct 25, 2019
Contributor
Author
|
LGTM! |
MattMarji
reviewed
Oct 28, 2019
MattMarji
reviewed
Oct 28, 2019
MattMarji
reviewed
Oct 28, 2019
MattMarji
reviewed
Oct 28, 2019
MattMarji
reviewed
Oct 28, 2019
MattMarji
reviewed
Oct 28, 2019
MattMarji
reviewed
Oct 28, 2019
MattMarji
reviewed
Oct 28, 2019
gkwang
approved these changes
Oct 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This update improves the SDK support for OpenID Connect. In particular, it modifies the sign in verification phase by substituting backchannel based checks with id_token validation where possible.
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist