Allow cookies to always have the Secure attribute if configured#59
Merged
lbalmaceda merged 3 commits intoauth0:masterfrom Jul 2, 2020
Merged
Conversation
lbalmaceda
suggested changes
Jul 2, 2020
| public void shouldSetSecureCookieWhenConfigured() { | ||
| String url = new AuthorizeUrl(client, request, response, "https://redirect.to/me", "code") | ||
| .withState("asdfghjkl") | ||
| .withSecureCookie(true) |
Contributor
There was a problem hiding this comment.
I'd add a test with this set to false, checking that when samesite=none this is still being set as secure even if we tell it not to with the setter. (the default behavior)
Contributor
Author
There was a problem hiding this comment.
Pushed a commit to add this test case 👍
Co-authored-by: Luciano Balmaceda <balmacedaluciano@gmail.com>
lbalmaceda
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Currently, cookies used for the
stateandnonceduring the authentication flow only set theSecureattribute ifSameSite=None(this happens if the response type includesid_token). This change allows configuration to always set theSecureattribute, regardless of the SameSite value.References
Closes #58
Testing
Checklist