Repackage JSON POJOs to domain packages#487
Merged
jimmyjames merged 1 commit intov2-devfrom Dec 20, 2022
Merged
Conversation
evansims
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, several JSON objects were packaged directly in the
com.auth0.json.mgmtpackage, whereas most are in domain-specific packages (e.g.,com.auth0.json.mgmt.jobs. This change moves all domain-related JSON objects into a domain package for cleaner code organization.Note for reviewers:
While the total files changed count is large, this is mostly due to updated entities and tests importing the new packaged type. The moved types are:
com.auth0.json.mgmt.Tokenmoved tocom.auth0.json.mgmt.blacklists.Tokencom.auth0.json.mgmt.ClientGrantmoved tocom.auth0.json.mgmt.clientgrants.ClientGrantcom.auth0.json.mgmt.ClientGrantsPagemoved tocom.auth0.json.mgmt.clientgrants.ClientGrantsPagecom.auth0.json.mgmt.Connectionmoved tocom.auth0.json.mgmt.connections.Connectioncom.auth0.json.mgmt.ConnectionsPagemoved tocom.auth0.json.mgmt.connections.ConnectionsPagecom.auth0.json.mgmt.DeviceCredentialsmoved tocom.auth0.json.mgmt.devicecredentials.DeviceCredentialscom.auth0.json.mgmt.EmailTemplatemoved tocom.auth0.json.mgmt.emailtemplates.EmailTemplatecom.auth0.json.mgmt.Grantmoved tocom.auth0.json.mgmt.grants.Grantcom.auth0.json.mgmt.GrantsPagemoved tocom.auth0.json.mgmt.grants.GrantsPagecom.auth0.json.mgmt.EmailVerificationIdentitymoved tocom.auth0.json.mgmt.tickets.EmailVerificationIdentitycom.auth0.json.mgmt.Key;moved tocom.auth0.json.mgmt.keys.Keycom.auth0.json.mgmt.RolesPagemoved tocom.auth0.json.mgmt.roles.RolesPagecom.auth0.json.mgmt.ResourceServermoved tocom.auth0.json.mgmt.resourceserver.ResourceServercom.auth0.json.mgmt.ResourceServersPagemoved tocom.auth0.json.mgmt.resourceserver.ResourceServersPagecom.auth0.json.mgmt.Permissionmoved tocom.auth0.json.mgmt.permissions.Permissioncom.auth0.json.mgmt.PermissionsPagemoved tocom.auth0.json.mgmt.permissions.PermissionsPagecom.auth0.json.mgmt.Rolemoved tocom.auth0.json.mgmt.roles.Rolecom.auth0.json.mgmt.RolesPagemoved tocom.auth0.json.mgmt.roles.RolesPagecom.auth0.json.mgmt.RulesConfigmoved tocom.auth0.json.mgmt.rules.RulesConfigcom.auth0.json.mgmt.Rulemoved tocom.auth0.json.mgmt.rules.Rulecom.auth0.json.mgmt.RulesPagemoved tocom.auth0.json.mgmt.rules.RulesPagecom.auth0.json.mgmt.DailyStatsmoved tocom.auth0.json.mgmt.stats.DailyStatscom.auth0.json.mgmt.Permissionmoved tocom.auth0.json.mgmt.permissions.Permissioncom.auth0.json.mgmt.PermissionsPagemoved tocom.auth0.json.mgmt.permissions.PermissionsPagecom.auth0.json.mgmt.RolesPagemoved tocom.auth0.json.mgmt.roles.RolesPage