Skip to content

[SDK-3180] Merge dictionary assignment with declaration ✨#297

Merged
evansims merged 3 commits intoauth0:masterfrom
GDGSNF:master
Mar 9, 2022
Merged

[SDK-3180] Merge dictionary assignment with declaration ✨#297
evansims merged 3 commits intoauth0:masterfrom
GDGSNF:master

Conversation

@yezz123
Copy link
Copy Markdown
Contributor

@yezz123 yezz123 commented Nov 2, 2021

Changes

When declaring a dictionary and filling it up with values one way that can come naturally is to declare it as empty and then add entries to it.

This can be done in place, shortening the code and making the intent more explicit. Now I just need to glance at one line to see that I'm filling a variable with hats, rather than four.

The same holds true for filling up other collection types like sets and lists.

There are also some other Refactoring functions...

References

I was just reading some parts of the codes, we want to integrate into a FastAPI project, that is why I would like to help the team refactor some functions ✨

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@yezz123 yezz123 requested a review from a team as a code owner November 2, 2021 10:55
@stale
Copy link
Copy Markdown

stale Bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale Bot added the closed:stale Issue or PR has not seen activity recently label Mar 2, 2022
@stale stale Bot removed the closed:stale Issue or PR has not seen activity recently label Mar 2, 2022
@evansims
Copy link
Copy Markdown
Contributor

evansims commented Mar 9, 2022

Hi @yezz123 👋 Thanks for your contribution! I'm unable to make changes to your PR due to fork permissions. However, if you could bring it up to date with the master branch once more we can look into getting these changes merged

@evansims evansims changed the title chore: Merge dictionary assignment with declaration ✨ [SDK-3180] Merge dictionary assignment with declaration ✨ Mar 9, 2022
@yezz123
Copy link
Copy Markdown
Contributor Author

yezz123 commented Mar 9, 2022

Hi @yezz123 👋 Thanks for your contribution! I'm unable to make changes to your PR due to fork permissions. However, if you could bring it up to date with the master branch once more we can look into getting these changes merged

Hy @evansims everything is fine i just update the branch

Copy link
Copy Markdown
Contributor

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨ Thanks for your help on this! 🚀

@evansims evansims merged commit a0395a9 into auth0:master Mar 9, 2022
@adamjmcgrath adamjmcgrath added this to the 3.22.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants