fix(types): allow user_id to accept int values in UserIdentitySchema#828
Open
armorbreak001 wants to merge 1 commit intoauth0:masterfrom
Open
fix(types): allow user_id to accept int values in UserIdentitySchema#828armorbreak001 wants to merge 1 commit intoauth0:masterfrom
armorbreak001 wants to merge 1 commit intoauth0:masterfrom
Conversation
GitHub identity providers (and possibly others) return user_id as an integer rather than a string. The current Optional[str] typing causes Pydantic validation errors when calling users.get() for such accounts. Relax the type to Union[str, int] to match the actual API behavior. Fixes auth0#826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub (and possibly other social) identity providers return
user_idas an integer in the identities array. The currentOptional[str]typing causes a Pydantic validation error when callingusers.get()for accounts linked with such providers:Changes
Relax the
user_idfield type fromOptional[str]toOptional[Union[str, int]]to match actual API behavior where the value can be either a string or an integer depending on the identity provider.Fixes #826