mgmt: Adds missing fields in Create/Update connections#929
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #929 +/- ##
==========================================
+ Coverage 79.36% 79.37% +0.01%
==========================================
Files 458 461 +3
Lines 5960 5973 +13
Branches 283 283
==========================================
+ Hits 4730 4741 +11
- Misses 1137 1139 +2
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nandan-bhat
reviewed
Mar 4, 2026
nandan-bhat
approved these changes
Mar 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds missing fields to the
CreateandUpdateconnection models to align with the Management API spec.New models:
ConnectionAuthenticationPurpose– configures the purpose of a connection for authentication during login (activeflag).ConnectionConnectedAccountsPurpose– configures the purpose of a connection for connected accounts and Token Vault (active,cross_app_access).ConnectionOptionsFederatedConnectionsAccessTokens– enables refresh tokens and access tokens collection for federated connections (active).Extended existing models:
ConnectionBase– addedAuthentication(ConnectionAuthenticationPurpose) andConnectedAccounts(ConnectionConnectedAccountsPurpose) properties.ConnectionOptions– addedFederatedConnectionsAccessTokens(ConnectionOptionsFederatedConnectionsAccessTokens) property. Fixed an incorrect<inheritdoc>reference onGatewayAuthentication.ConnectionOptionsAttributeIdentifier– addedDefaultMethodproperty backed by the newConnectionOptionsAttributeDefaultMethodenum (password,email_otp).ConnectionOptionsPasswordAuthenticationMethod– addedApiBehavior(required|optional) andSignupBehavior(allow|block) properties backed by new enums.ConnectionOptionsEmailAttribute– addedUniqueboolean property.ConnectionOptionsEmailOtpAuthenticationMethodandConnectionOptionsPhoneOtpAuthenticationMethodclasses.References
Fixes #924
Testing
Integration tests in
ConnectionTests.cswere updated to exercise the newly added fields:ConnectionOptionsEmailAttribute.Uniqueis set totruein the test fixture.ConnectionOptionsPasswordAuthenticationMethod.ApiBehaviorandSignupBehaviorare set toRequiredandAllowrespectively.Checklist