-
Notifications
You must be signed in to change notification settings - Fork 33
Edit for Customize Email section #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nick-gagliardi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Amazing work, and I love the new IA structure. This is much friendlier from a usability and navigation perspective. Few edits, take a look & let me know if you have any questions!
main/docs/customize/email/send-email-invitations-for-application-signup.mdx
Show resolved
Hide resolved
main/docs/customize/email/send-email-invitations-for-application-signup.mdx
Outdated
Show resolved
Hide resolved
| "docs/customize/email/smtp-email-providers/mailgun", | ||
| "docs/customize/email/smtp-email-providers/smtp-server", | ||
| { | ||
| "group": "Custom Configuration with Actions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logically this makes sense, though I am a little worried about this being nested so far. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i hemmed and hawed about it myself, honestly. ultimately, i went this way to organize it parallel to all the other ways to set up external smtp because one of the things i myself was confused about when i first read these docs was why it was separated out.
imnsho, i think the no-good-answers situation here is indicative of a bigger organizational issue (e.g. why is setting up an smtp provider, a core part of using email workflows at all, nested deep in a customization section?).
but, barring solving a big IA question, i'm open to suggestions on moving this section around. lmk if you have thoughts on where it might go best?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @daniloasis-auth0 : relevant to our conversation this morning
Co-authored-by: Nick Gagliardi <133918568+nick-gagliardi@users.noreply.github.com>
Co-authored-by: Nick Gagliardi <133918568+nick-gagliardi@users.noreply.github.com>
a major pass at reorganizing the customize emails section of the docs.
the diff is gnarly, so i recommend reviewing (at least initially) by browsing the existing docs in prod to get somewhat familiar with the starting point, and then reading the docs in the deploy preview here nose to tail.
this was primarily a structural edit, but i confirmed a lot of technical info as well, like supported liquid syntax, the functionality of some template parameters, etc. please confirm i correctly nabbed all the necessary redirects as well.