Skip to content

Update guava to version 27.0.1-jre#54

Merged
lbalmaceda merged 2 commits intoauth0:masterfrom
golszewski86:master
Mar 28, 2019
Merged

Update guava to version 27.0.1-jre#54
lbalmaceda merged 2 commits intoauth0:masterfrom
golszewski86:master

Conversation

@golszewski86
Copy link
Copy Markdown
Contributor

There is a problem in com.google.guava:guava:27.0-jre - jar contains duplicate classes from com.google.guava:failureaccess:1.0 on which it also depends:
google/guava#3302

Since this library depends on Google Guava, using it as dependency causes my build to fail:

[WARNING] Found duplicate (but equal) classes in [com.google.guava:failureaccess:1.0,com.google.guava:guava:27.0-jre] :
[WARNING]   com.google.common.util.concurrent.internal.InternalFutureFailureAccess
[WARNING]   com.google.common.util.concurrent.internal.InternalFutures

The problem was fixed in guava 27.0.1 (please see https://github.com/google/guava/releases/tag/v27.0.1) hence the version update.

@lbalmaceda
Copy link
Copy Markdown
Contributor

@golszewski86 what about changing it to 27.1-jre?

@golszewski86
Copy link
Copy Markdown
Contributor Author

@lbalmaceda I'm fine with any version above 27.0-jre

@lbalmaceda
Copy link
Copy Markdown
Contributor

Please change it to 27.1-jre then and I'll merge. Thanks!

@golszewski86
Copy link
Copy Markdown
Contributor Author

@lbalmaceda ping

@lbalmaceda lbalmaceda added this to the v0-Next milestone Mar 28, 2019
@lbalmaceda lbalmaceda merged commit 906a6cc into auth0:master Mar 28, 2019
@lbalmaceda lbalmaceda modified the milestones: v0-Next, 0.8.0 Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants