Problems when minifying Lock concatenated with other files

[mgonto]

Please refer to auth0/auth0-angular#96

[kevinob11]

I'm seeing this same issue, when I minify / uglify with auth0-lock.js I see the same error mentioned in the above linked thread.

[mgonto]

Related also to auth0/auth0-angular#121

[mgonto]

Hey @kevinob11,

we're working on tackling this issue. Can you provide us a sample project to reproduce it?

Thanks!

[kevinob11]

Yep, I'll need to pull it out of my private repo. I'll be working on that Wednesday, I'll try to get it to you then!

[mgonto]

Awesome thanks for the help :D

[johnstontrav]

Hey @mgonto,

Here is a seed project:

https://bitbucket.org/Johnstontrav/auth0-seed-issue-94

It is built with https://github.com/Swiip/generator-gulp-angular

Once cloned, run steps:

1. npm install && bower install
2. edit file: src/app/index.js
3. update the Auth0 settings.
4. gulp serve - firebug should report "Client configuration loaded"
5. gulp serve:dist - should report the error.

Let me know if I can help further.

[kevinob11]

That looks right to me, generator-gulp-angular is the exact generator I used, though I think you will need to run gulp:build so you have the dist folder before running gulp serve:dist.

[mgonto]

Awesome thanks for the seed project reproducing it. @cristiandouce can you now check this out :)?

[cristiandouce]

After debugging this a while, I've come with the problem... not yet the solution though.

Using chrome dev tools I've found this:

Which, as we can see... auth0-angular isn't parsing the variables according to Auth0Lock spec.

This is because of some resolve auth0-angular does on the constructor name, to detect whether you are using Auth0Lock or Auth0.js.

This check on the Constructor name, is broken once mangling and minifying stuff together, since the uglify tool does not know that Auth0Lock should be defined globally so auth0-angular could resolve how to parse the initialization variables.

That's why when mangle: false everything works as expected!

@mgonto will continue the follow of this in auth0/auth0-angular#96 and auth0/auth0-angular#121

The temporary solution to this would be either load the auth0-lock.min.js script outside the minifying or providing the mangle: false setup to the uglify tool.

This will also be added to the auth0-angular Readme as a common error.

[cristiandouce]

Closing now, since it's confirmed a bug in how auth0-angular resolves fnNames for Constructors.

Here, in Chrome's devtools console you can type:

r === Auth0Lock
// > true

But, the fnName is r which is not equal to Auth0Lock 🎯

[mgonto]

At all, it has been fixed with version 4.0.1 of auth0-angular :).

I've also submited a PR to the sample proving it's working now :).

https://bitbucket.org/Johnstontrav/auth0-seed-issue-94/pull-request/1/fix-with-auth0-angular-401

Cheers!

[kevinob11]

Should 4.0.1 be v4.0.1 or am I missing something in the tag naming convention?