-
Notifications
You must be signed in to change notification settings - Fork 435
feat: add support for connected accounts #2344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2344 +/- ##
==========================================
- Coverage 88.58% 87.51% -1.07%
==========================================
Files 32 34 +2
Lines 3109 3517 +408
Branches 615 657 +42
==========================================
+ Hits 2754 3078 +324
- Misses 352 436 +84
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Claude finished @frederikprijck's task —— View job PR Review CompleteI've completed a comprehensive review of this PR that adds Connected Accounts support to the nextjs-auth0 SDK. Overall Assessment❌ This PR requires fixes before merging. I've identified several security and reliability issues that should be addressed, including missing input validation, potential null pointer exceptions, and error handling improvements. Additionally, there are typos in error messages and opportunities to improve OAuth2 security patterns. Key Issues FoundCritical Issues:
Security Improvements:
Code Quality:
All specific issues have been commented inline on the affected lines. |
📋 Changes
This PR adds support for the Connected Accounts flow:
/auth/connect
to initiate connect account flowconnectAccount()
method for custom route implementationsonCallback
hook to handle connected account responsesMounted route:
Programmatically via:
The
onCallback
hook now receives additional context for connected account flows:connectedAccount
: Account linking response dataresponseType
: Set toRESPONSE_TYPES.CONNECT_CODE
for account linkingreturnTo
: Original return URL from the linking initiation