Skip to content

Conversation

frederikprijck
Copy link
Member

This PR ensures that the Fetcher honors the token_type when DPoP is configured:

  • If the token_type is bearer, we will not set the DPoP scheme and the DPoP header.
  • if the token_type is dpop, we will set both.

@frederikprijck frederikprijck requested a review from a team as a code owner October 17, 2025 10:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.44%. Comparing base (483663a) to head (d82a554).

Files with missing lines Patch % Lines
src/server/fetcher.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
+ Coverage   85.18%   86.44%   +1.25%     
==========================================
  Files          37       37              
  Lines        4051     4064      +13     
  Branches      777      793      +16     
==========================================
+ Hits         3451     3513      +62     
+ Misses        597      548      -49     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frederikprijck frederikprijck merged commit a0c120c into main Oct 17, 2025
10 checks passed
@frederikprijck frederikprijck deleted the fix/fetcher-dpop branch October 17, 2025 15:44
This was referenced Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants