Skip to content

Conversation

@fern-api
Copy link
Contributor

@fern-api fern-api bot commented Dec 10, 2025

Changes

This reverts the breaking change to customDomains.list() introduced in a previous PR.

Reverted: Custom Domains API pagination change

The customDomains.list() method has been reverted to its original behaviour, returning a simple array of custom domains instead of a paginated response.

Before (breaking - now reverted):

// Paginated response - NO LONGER THE CASE
const page = await client.customDomains.list({ take: 50, from: "cursor" });
for await (const domain of page) {
    console.log(domain);
}

After (restored original behavior):

// Simple array response - RESTORED
const domains = await client.customDomains.list({
    q: "query",
    fields: "fields",
    include_fields: true,
    sort: "sort"
});
// Returns: CustomDomain[]

Parameters removed:

  • take - No longer needed
  • from - No longer needed

Return type changed:

  • From: core.Page<Management.CustomDomain, ...> (paginated)
  • To: Management.CustomDomain[] (simple array)

This ensures backward compatibility with existing code that expects an array response.

References

Internal API definition update

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@fern-api fern-api bot requested a review from a team as a code owner December 10, 2025 15:31
@developerkunal developerkunal changed the title 🌿 Fern Regeneration -- December 10, 2025 fix: Revert Custom Domains pagination to return simple array Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.91%. Comparing base (1de06e5) to head (06b394a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ement/api/resources/customDomains/client/Client.ts 90.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
- Coverage   88.92%   88.91%   -0.01%     
==========================================
  Files         371      371              
  Lines       16905    16896       -9     
  Branches     8526     8371     -155     
==========================================
- Hits        15032    15023       -9     
  Misses       1873     1873              
Flag Coverage Δ
alltests 88.91% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/management/api/requests/requests.ts 100.00% <ø> (ø)
src/management/api/types/types.ts 100.00% <ø> (ø)
...ement/api/resources/customDomains/client/Client.ts 88.40% <90.00%> (-0.41%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@developerkunal developerkunal enabled auto-merge (squash) December 10, 2025 15:47
@developerkunal developerkunal merged commit 874572e into master Dec 10, 2025
10 checks passed
@developerkunal developerkunal deleted the fern-bot/2025-12-10T15-31Z branch December 10, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants