fix: Revert Custom Domains pagination to return simple array #1280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This reverts the breaking change to
customDomains.list()introduced in a previous PR.Reverted: Custom Domains API pagination change
The
customDomains.list()method has been reverted to its original behaviour, returning a simple array of custom domains instead of a paginated response.Before (breaking - now reverted):
After (restored original behavior):
Parameters removed:
take- No longer neededfrom- No longer neededReturn type changed:
core.Page<Management.CustomDomain, ...>(paginated)Management.CustomDomain[](simple array)This ensures backward compatibility with existing code that expects an array response.
References
Internal API definition update
Testing
Checklist