Added prefix option and fixed moment warning #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernanhht
reviewed
Nov 15, 2016
| getKeyInfo: function () { | ||
| return "<X509Data><X509Certificate>" + cert + "</X509Certificate></X509Data>"; | ||
| getKeyInfo: function (key, prefix) { | ||
| prefix = prefix ? prefix + ':' : prefix; |
Contributor
There was a problem hiding this comment.
prefix can be anything ?
Contributor
Author
There was a problem hiding this comment.
prefix is a string, added a typeof validation (and test) to make sure it's a string.
mcastany
force-pushed
the
prefix-option
branch
from
dcecfab to
b6ffac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new
option.prefixto set the signature prefix. Also fixed a warning with moment