fix: catch possible SAML response signing error#112
Conversation
luuuis
left a comment
There was a problem hiding this comment.
CI is failing; perhaps state is carrying across from one test to another.
| }); | ||
|
|
||
| describe('when invalid signing key is used', function () { | ||
| before(function () { |
There was a problem hiding this comment.
Do you need to undo this in after?
There was a problem hiding this comment.
Good point! I've added after to clean up after the test execution, even though it was not a reason why tests were failing (see the comment below).
|
I found that the same error happens in master branch, after some investigation it turns out the issue is caused by the new release of I've pinned previosly used |

Description
This PR allows to catch an error that might happen due to invalid signing key (badly formatted) during SAML response signing.
Testing