Accept multiple SessionIndex elements in SP-initated LogoutRequests#117
Merged
4 commits merged intomasterfrom Feb 23, 2021
Merged
Accept multiple SessionIndex elements in SP-initated LogoutRequests#1174 commits merged intomasterfrom
4 commits merged intomasterfrom
Conversation
ghost
commented
Feb 12, 2021
Comment on lines
+68
to
72
| * @serviceProviderId {string} The serviceProviderId value of the session participant | ||
| * @sessionIndex {string} The sessionIndex of the session participant | ||
| * @nameId {string} The nameId of the session participant | ||
| * @cb {function} The callback that will be called with '(err, removedElement)' | ||
| */ |
Author
There was a problem hiding this comment.
No functionality change here but it seems that there was some copy-pasting from the get method above and some of the method arguments and comments did not make sense with how the function was being used.
ghost
marked this pull request as ready for review
luuuis
reviewed
Feb 16, 2021
luuuis
approved these changes
Feb 22, 2021
ziluvatar
approved these changes
Feb 23, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for multiple
SessionIndexelements in SP-initiated LogoutRequests in accordance with the specification:SessionParticipantsAPI and requires a major version bumpThe changes introduced in this PR:
SessionIndexvalue in an SP-initiated logout request are extracted (previously only the first one)SessionParticipants#getcan be called with either an array of session indices or a single session index (previously only a single session index string value)References
Testing