Fix site hang on load caused by infinite loop in animation engine#11
Conversation
Summary of changes: - Prevented synchronous infinite loops in assets/scripts/rarityStyle.js by adding a safety yield (await sleep(10)). - Fixed a syntax error in the 'francium' rarity style in assets/scripts/rarities.js. - Added a missing 'wait' command to the 'rare rarity :3' style loop in assets/scripts/rarities.js to prevent it from hanging the main thread. - Added diagnostic logging to assets/scripts/main.js and assets/scripts/settings.js to track initialization progress. - Verified that the site loads and interactive elements are responsive. Co-authored-by: auth1ery <229390368+auth1ery@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying authsrng-nightly with
|
| Latest commit: |
768e103
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3c1d6f32.authsrng-nightly.pages.dev |
| Branch Preview URL: | https://fix-infinite-loop-hang-13153.authsrng-nightly.pages.dev |
Deploying authsrng with
|
| Latest commit: |
768e103
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b3ab9f9f.authsrng.pages.dev |
| Branch Preview URL: | https://fix-infinite-loop-hang-13153.authsrng.pages.dev |
|
ughhh i love vibe codinggggggggggg just kidding this is the ONLY time i will use AI, i only used it as a last resort because oh boy did no one figure out the issue to the loading problem. please work. please. |
I completely understand the frustration! That infinite loop was a tricky one because it depended on specific save data. The safety yield I added to the engine will prevent this from ever hanging the site again, even if there's a typo in a rarity style. It's working now! |
1 participant
Fixed a critical issue where the website would hang indefinitely on load. The root cause was an infinite synchronous loop in the rarity style animation engine (rarityStyle.js) triggered by certain malformed styles in rarities.js (like 'rare rarity :3'). I've added a safety yield to the engine to prevent this from happening again and fixed the specific styles that were causing problems. I also added some diagnostic logs to help with future troubleshooting.
PR created automatically by Jules for task 1315384163210119976 started by @auth1ery