Skip to content

if pwd exists use that and dont create a new one #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2025
Merged

if pwd exists use that and dont create a new one #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e5abe2
if pwd exists use that and dont create a new one
Satyam1023 Apr 28, 2025
c75d3fa
binary
ritamAN77 Apr 28, 2025
92bc591
binary
ritamAN77 Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified authnull-db-agent
View file
Open in desktop
Binary file not shown.
54 changes: 48 additions & 6 deletions src/pkg/checkout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,11 +340,53 @@ func GenerateCredentials(db *sql.DB, Config DBConfig, dbName string, dbUserName
}
//Rotate the Credentials for the DB User in the Database
//Step1 : Generate a Random Password for the DB User
password, err := GenerateRandomPassword(16)
//password, err := GenerateRandomPassword(16)
//if err != nil {
// log.Printf("Error while generating random password: %v", err)
// return false, err
// }
var password string
proxySQLDB, err := ConnectToProxysqlDB(Config)
if err != nil {
log.Printf("Error while connecting to ProxySQL database: %v", err)
return false, err
}
// Before checking the password, first verify the user exists
var userExists int
checkUserExistsQuery := fmt.Sprintf("SELECT COUNT(*) FROM mysql_users WHERE username = '%s'", dbUserName)
err = proxySQLDB.QueryRow(checkUserExistsQuery).Scan(&userExists)
if err != nil {
log.Printf("Error while generating random password: %v", err)
log.Printf("Error checking if user exists in ProxySQL: %v", err)
return false, err
}

if userExists > 0 {
// User exists, let's get the password
var existingPassword string
checkExistingPasswordQuery := fmt.Sprintf("SELECT password FROM mysql_users WHERE username = '%s'", dbUserName)
err = proxySQLDB.QueryRow(checkExistingPasswordQuery).Scan(&existingPassword)
if err != nil {
log.Printf("Error retrieving password for user %s: %v", dbUserName, err)
return false, err
}

if existingPassword != "" {
log.Printf("Existing password found for user %s, skipping password rotation", dbUserName)
password = existingPassword
} else {
log.Printf("User exists but has empty password, generating new one")
password, err = GenerateRandomPassword(16)
if err != nil {
return false, err
}
}
} else {
// User doesn't exist, generate new password
password, err = GenerateRandomPassword(16)
if err != nil {
return false, err
}
}
var dbhost string
err = db.QueryRow("SELECT host FROM mysql.user WHERE user = ? LIMIT 1", dbUserName).Scan(&dbhost)
if err != nil {
Expand Down Expand Up @@ -381,10 +423,10 @@ func GenerateCredentials(db *sql.DB, Config DBConfig, dbName string, dbUserName
}

//COnnect to ProxysqlDB
proxySQLDB, err := ConnectToProxysqlDB(Config)
if err != nil {
log.Printf("Error while connecting to ProxySQL database: %v", err)
}
//proxySQLDB, err := ConnectToProxysqlDB(Config)
//if err != nil {
// log.Printf("Error while connecting to ProxySQL database: %v", err)
//}
//Create the user in ProxySQL
// Check if the user already exists in ProxySQL
checkUserQuery := fmt.Sprintf("SELECT COUNT(*) FROM mysql_users WHERE username = '%s'", dbUserName)
Expand Down