Skip to content

fix(token): use safe type assertions for JWT claims [H2] #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakhansamani merged 1 commit into from
Apr 4, 2026
Merged

fix(token): use safe type assertions for JWT claims [H2] #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions internal/token/auth_token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,13 +254,16 @@ func (p *provider) ValidateAccessToken(gc *gin.Context, accessToken string) (map
return res, err
}

userID := res["sub"].(string)
nonce := res["nonce"].(string)
userID, ok := res["sub"].(string)
if !ok || userID == "" {
return res, fmt.Errorf(`unauthorized: missing sub claim`)
}
nonce, _ := res["nonce"].(string)

loginMethod := res["login_method"]
loginMethod, _ := res["login_method"].(string)
sessionKey := userID
if loginMethod != nil && loginMethod != "" {
sessionKey = loginMethod.(string) + ":" + userID
if loginMethod != "" {
sessionKey = loginMethod + ":" + userID
}

token, err := p.dependencies.MemoryStoreProvider.GetUserSession(sessionKey, constants.TokenTypeAccessToken+"_"+nonce)
Expand Down Expand Up @@ -303,13 +306,16 @@ func (p *provider) ValidateRefreshToken(gc *gin.Context, refreshToken string) (m
return res, err
}

userID := res["sub"].(string)
nonce := res["nonce"].(string)
userID, ok := res["sub"].(string)
if !ok || userID == "" {
return res, fmt.Errorf(`unauthorized: missing sub claim`)
}
nonce, _ := res["nonce"].(string)

loginMethod := res["login_method"]
loginMethod, _ := res["login_method"].(string)
sessionKey := userID
if loginMethod != nil && loginMethod != "" {
sessionKey = loginMethod.(string) + ":" + userID
if loginMethod != "" {
sessionKey = loginMethod + ":" + userID
}
token, err := p.dependencies.MemoryStoreProvider.GetUserSession(sessionKey, constants.TokenTypeRefreshToken+"_"+nonce)
if nonce == "" || err != nil {
Expand Down Expand Up @@ -509,9 +515,15 @@ func (p *provider) GetUserIDFromSessionOrAccessToken(gc *gin.Context) (*SessionO
p.dependencies.Log.Debug().Err(err).Msg("Failed to validate access token")
return nil, fmt.Errorf(`unauthorized`)
}
userID, ok := claims["sub"].(string)
if !ok || userID == "" {
return nil, fmt.Errorf(`unauthorized: missing sub claim`)
}
loginMethod, _ := claims["login_method"].(string)
nonce, _ := claims["nonce"].(string)
return &SessionOrAccessTokenData{
UserID: claims["sub"].(string),
LoginMethod: claims["login_method"].(string),
Nonce: claims["nonce"].(string),
UserID: userID,
LoginMethod: loginMethod,
Nonce: nonce,
}, nil
}