Skip to content

fix(crypto): use crypto/rand for HMAC key generation [M3] #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakhansamani merged 1 commit into from
Apr 4, 2026
Merged

fix(crypto): use crypto/rand for HMAC key generation [M3] #560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions internal/crypto/hmac.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
package crypto

import (
"github.com/google/uuid"
"crypto/rand"
"encoding/hex"
)

// NewHMAC key returns new key that can be used to ecnrypt data using HMAC algo
// returns key, string, error
// NewHMACKey returns a new cryptographically random key for HMAC signing.
func NewHMACKey(algo, keyID string) (string, string, error) {
key := uuid.New().String()
keyBytes := make([]byte, 32)
if _, err := rand.Read(keyBytes); err != nil {
return "", "", err
}
key := hex.EncodeToString(keyBytes)
jwkPublicKey, err := GetPubJWK(algo, keyID, []byte(key))
if err != nil {
return "", "", err
Expand Down