Skip to content

fix(security): use constant-time comparison for client secret and OTP #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakhansamani merged 1 commit into from
Apr 4, 2026
+6 −3
Merged

fix(security): use constant-time comparison for client secret and OTP #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/graphql/reset_password.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package graphql

import (
"context"
"crypto/subtle"
"fmt"
"strings"
"time"
Expand Down Expand Up @@ -110,7 +111,7 @@ func (g *graphqlProvider) ResetPassword(ctx context.Context, params *model.Reset
log.Debug().Err(err).Msg("Failed to get otp request by phone number")
return nil, fmt.Errorf(`invalid otp`)
}
if otpRequest.Otp != otp {
if subtle.ConstantTimeCompare([]byte(otpRequest.Otp), []byte(otp)) != 1 {
log.Debug().Msg("Failed to verify otp request: Incorrect value")
return nil, fmt.Errorf(`invalid otp`)
}
Expand Down
3 changes: 2 additions & 1 deletion internal/graphql/verify_otp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package graphql

import (
"context"
"crypto/subtle"
"fmt"
"strings"
"time"
Expand Down Expand Up @@ -105,7 +106,7 @@ func (g *graphqlProvider) VerifyOTP(ctx context.Context, params *model.VerifyOTP
log.Debug().Msg("OTP not found")
return nil, fmt.Errorf(`OTP not found`)
}
if params.Otp != otp.Otp {
if subtle.ConstantTimeCompare([]byte(params.Otp), []byte(otp.Otp)) != 1 {
log.Debug().Msg("Failed to verify otp request: OTP mismatch")
return nil, fmt.Errorf(`invalid otp`)
}
Expand Down
3 changes: 2 additions & 1 deletion internal/http_handlers/token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package http_handlers

import (
"crypto/sha256"
"crypto/subtle"
"encoding/base64"
"net/http"
"strings"
Expand Down Expand Up @@ -158,7 +159,7 @@ func (h *httpProvider) TokenHandler() gin.HandlerFunc {
}

} else {
if clientSecret != h.Config.ClientSecret {
if subtle.ConstantTimeCompare([]byte(clientSecret), []byte(h.Config.ClientSecret)) != 1 {
log.Debug().Msg("Client secret is invalid")
gc.JSON(http.StatusUnauthorized, gin.H{
"error": "invalid_client",
Expand Down