Skip to content

refactor: strengthen DID typing#84

Merged
bordumb merged 2 commits intomainfrom
fn-62
Mar 11, 2026
Merged

refactor: strengthen DID typing#84
bordumb merged 2 commits intomainfrom
fn-62

Conversation

@bordumb
Copy link
Copy Markdown
Contributor

@bordumb bordumb commented Mar 11, 2026

No description provided.

@bordumb bordumb self-assigned this Mar 11, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
auths Ready Ready Preview, Comment Mar 11, 2026 6:03pm

@github-actions
Copy link
Copy Markdown

Auths Commit Verification

Commit Status Details
04798869 ❌ Failed No signature found
e1375310 ❌ Failed No signature found

Result: ❌ 0/2 commits verified


How to fix

Commit 04798869 is not signed. Install auths and re-sign:

macOS: brew install auths
Linux: Download from releases

Then re-sign:

git rebase HEAD~2 --exec 'git commit --amend --no-edit -S'
git push --force-with-lease

Quickstart →

@bordumb bordumb changed the title Fn 62 refactor: strengthen DID typing Mar 11, 2026
bordumb added 2 commits March 11, 2026 18:02
…Str for DID types (fn-62.1)

Add validation infrastructure to DeviceDID and IdentityDID without breaking
existing code. DeviceDID::parse() validates strict did:key:z prefix,
IdentityDID::parse() validates strict did:keri: prefix. Adds FromStr impls,
IdentityDID::from_prefix() and prefix() helpers ported from ValidatedIdentityDID.
…, add clippy + tests (fn-62.2-62.5)

- Make DeviceDID(String) and IdentityDID(String) fields private
- Rename new() to new_unchecked() on both types
- Convert From<String>/From<&str> to TryFrom with validation
- Add validated serde Deserialize impl via parse()
- Fix all 100+ construction sites across workspace
- Add FFI boundary validation with DeviceDID::parse()
- Delete ValidatedIdentityDID from auths-core (consolidated into IdentityDID)
- Add per-crate clippy.toml for auths-cli with DID construction lints
- Add comprehensive TryFrom, serde round-trip, and error tests
@github-actions
Copy link
Copy Markdown

Auths Commit Verification

Commit Status Details
d04d0a45 ✅ Verified Signed by z6MktnihicwetvA16FtHFynaJTn9eDZw51eizUEA1yGJCR4o@auths.local
532860fb ✅ Verified Signed by z6MktnihicwetvA16FtHFynaJTn9eDZw51eizUEA1yGJCR4o@auths.local

Result: ✅ 2/2 commits verified

@bordumb bordumb merged commit 9733c84 into main Mar 11, 2026
9 of 12 checks passed
@bordumb bordumb deleted the fn-62 branch March 11, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant