Implement ExitIdle on the balancer #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
authzedbot
added a commit
to authzed/cla
that referenced
this pull request
Aug 27, 2025
Contributor
|
The lint failure is an issue with an upstream action. I'll go take a look at it. |
Contributor
|
It should pass if you rebase now. |
go-grpc@1.74.0 introduced a breaking change to the balancer.Balancer interface by introducing a new method. To still satisfy that interface we need to implement ExitIdle. It's been an optional part of the balancer, as a seperate interface, for quite a while. And since it's not implementing ExitIdle already, I assume it's safe to do a no-op.
tokongs
force-pushed
the
tobias/implement-balancer-1.74
branch
from
09c7079 to
8866abb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
go-grpc@1.74.0 introduced a breaking change to the balancer.Balancer interface by introducing a new method. To still satisfy that interface we need to implement ExitIdle. It's been an optional part of the balancer, as a seperate interface, for quite a while. And since it's not implementing ExitIdle already, I assume it's safe to do a no-op.
Testing
No new behavior is added. I guess it could be better verified that it complies with the interface by upgrading to go-grpc >1.74.0.
References
#1
grpc/grpc-go#8345