Skip to content

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Oct 3, 2025

Addresses #531

Before

[16:24:26] ~/Documents/GitHub/zed (write-schema-tests) $ cat ~/Desktop/basicschema.zed|  go run ./cmd/zed/main.go schema write
4:24PM ERR terminated with errors error="must provide file path or contents via stdin"
exit status 1

After

[16:24:53] ~/Documents/GitHub/zed (write-schema-tests) $ cat ~/Desktop/basicschema.zed|  go run ./cmd/zed/main.go schema write
4:26PM WRN not calling a released version of SpiceDB version=v1.45.5-0.20250923215517-7491a826fc13+enterprise.devel.(devel)

@miparnisari miparnisari force-pushed the write-schema-tests branch 5 times, most recently from c82ef52 to d4a6655 Compare October 3, 2025 23:54
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coupla WIP comments

@miparnisari miparnisari marked this pull request as ready for review October 6, 2025 17:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.06%. Comparing base (7ed5ab0) to head (7a65897).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/schema.go 33.33% 13 Missing and 1 partial ⚠️
internal/commands/schema.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   39.28%   40.06%   +0.78%     
==========================================
  Files          37       37              
  Lines        5448     5473      +25     
==========================================
+ Hits         2140     2193      +53     
+ Misses       3063     3029      -34     
- Partials      245      251       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miparnisari miparnisari force-pushed the write-schema-tests branch 4 times, most recently from 9db48d7 to 1dd922b Compare October 6, 2025 19:13
@miparnisari miparnisari requested a review from tstirrat15 October 6, 2025 19:21
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miparnisari miparnisari merged commit 57fdb03 into main Oct 8, 2025
11 checks passed
@miparnisari miparnisari deleted the write-schema-tests branch October 8, 2025 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants