Skip to content

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Oct 7, 2025

Description

Releases to Windows have never been successful: https://github.com/authzed/zed/actions/workflows/release-windows.yml

• running goreleaser v2.3.2-pro (outdated, latest is v2.12.5)
  ⨯ release failed after 0s                  error=failed to load configuration: yaml: unmarshal errors:
  line 26: field chocolatey not found in type config.Project

I am:

  • Updating goreleaser to v2.12.5
  • Running goreleaser check .goreleaser.* and addressing some of the low-hanging fruits.
  • Sending a message via Slack if the release fails for any of the supported platforms.

Verification

Before this PR:

zed (main) $ goreleaser check .goreleaser.*
  • by using this software you agree with its EULA, available at https://goreleaser.com/eula
  • running goreleaser v2.12.5
  • checking                                  path=.goreleaser.docker.yml
  • pipe skipped or partially skipped                reason=release is disabled
  • dockers and docker_manifests are being phased out and will eventually be replaced by dockers_v2, check https://goreleaser.com/deprecations#dockers for more info
  • dockers and docker_manifests are being phased out and will eventually be replaced by dockers_v2, check https://goreleaser.com/deprecations#dockers for more info
  ⨯ command failed                                  
    error=
    │ failed to load configuration: yaml: unmarshal errors:
    │   line 26: field chocolatey not found in type config.Project

With this PR:

$ goreleaser check .goreleaser.*
  • by using this software you agree with its EULA, available at https://goreleaser.com/eula
  • running goreleaser v2.12.5
  • checking                                  path=.goreleaser.docker.yml
  • pipe skipped or partially skipped                reason=release is disabled
  • dockers and docker_manifests are being phased out and will eventually be replaced by dockers_v2, check https://goreleaser.com/deprecations#dockers for more info
  • dockers and docker_manifests are being phased out and will eventually be replaced by dockers_v2, check https://goreleaser.com/deprecations#dockers for more info
  • checking                                  path=.goreleaser.windows.yml
  • checking                                  path=.goreleaser.yml
  • brews is being phased out in favor of homebrew_casks, check https://goreleaser.com/deprecations#brews for more info
  • 3 configuration file(s) validated
  • thanks for using GoReleaser Pro!

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.54%. Comparing base (7ed5ab0) to head (f324c91).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   39.28%   39.54%   +0.26%     
==========================================
  Files          37       37              
  Lines        5448     5467      +19     
==========================================
+ Hits         2140     2162      +22     
+ Misses       3063     3060       -3     
  Partials      245      245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miparnisari miparnisari force-pushed the fix-goreleaser-files branch 3 times, most recently from 5dd4f88 to 9bfa55c Compare October 7, 2025 23:00
@miparnisari miparnisari marked this pull request as ready for review October 7, 2025 23:03
@miparnisari miparnisari force-pushed the fix-goreleaser-files branch 2 times, most recently from 6c62366 to 06ef25c Compare October 7, 2025 23:18
@miparnisari miparnisari force-pushed the fix-goreleaser-files branch from 06ef25c to f324c91 Compare October 7, 2025 23:22
GORELEASER_KEY: "${{ secrets.GORELEASER_KEY }}"
- name: "Obtain container image to scan"
run: 'echo "IMAGE_VERSION=$(jq .version dist/linux_amd64_v1/metadata.json --raw-output)" >> $GITHUB_ENV'
run: |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

  • notice the change from dist/linux_amd64_v1 to dist/linux_amd64, introduced by the new goreleaser version
  • made it so that if this step fails, the next one doesn't run

Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@miparnisari miparnisari merged commit 445783d into main Oct 8, 2025
11 checks passed
@miparnisari miparnisari deleted the fix-goreleaser-files branch October 8, 2025 00:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants