Skip to content

[WIP] Added sphinx opengraph meta tags support#3159

Merged
gradientsky merged 1 commit intoautogluon:masterfrom
gradientsky:2023_04_18_meta_tags
Apr 19, 2023
Merged

[WIP] Added sphinx opengraph meta tags support#3159
gradientsky merged 1 commit intoautogluon:masterfrom
gradientsky:2023_04_18_meta_tags

Conversation

@gradientsky
Copy link
Copy Markdown
Contributor

@gradientsky gradientsky commented Apr 19, 2023

Issue #, if available:
#3084

Description of changes:
Added sphinx opengraph plugin

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gradientsky gradientsky added the API & Doc Improvements or additions to documentation label Apr 19, 2023
@gradientsky gradientsky force-pushed the 2023_04_18_meta_tags branch from 0f8a994 to b1ad451 Compare April 19, 2023 07:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2023

Job PR-3159-0f8a994 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3159/0f8a994/index.html

@gradientsky gradientsky force-pushed the 2023_04_18_meta_tags branch from b1ad451 to 3c4fb93 Compare April 19, 2023 08:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2023

Job PR-3159-b1ad451 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3159/b1ad451/index.html

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2023

Job PR-3159-3c4fb93 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3159/3c4fb93/index.html

gidler
gidler approved these changes Apr 19, 2023
View reviewed changes
docs/conf.py Outdated
Comment on lines +89 to +90
background_color="white"
line_color = "#2b8cee"
Copy link
Copy Markdown
Contributor

@gidler gidler Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why did we need to set these two config values? I don't see a reference to them in the open graph extension or docs.

Copy link
Copy Markdown
Contributor Author

@gradientsky gradientsky Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seems do not have effect I was expecting. I removed these.

@gradientsky gradientsky force-pushed the 2023_04_18_meta_tags branch from 3c4fb93 to 98bbfdd Compare April 19, 2023 17:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2023

Job PR-3159-98bbfdd is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3159/98bbfdd/index.html

@gradientsky gradientsky merged commit 381b874 into autogluon:master Apr 19, 2023
@gradientsky gradientsky deleted the 2023_04_18_meta_tags branch April 19, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gidler gidler gidler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

API & Doc Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gradientsky @gidler