Fix/list handling#74
Merged
Merged
Conversation
added 6 commits
May 20, 2026 15:42
when response is a list of a single list of dict, it has to be handled separately
This reverts commit 58128b7.
when response is a list of a single list of dict, it has to be handled separately
This reverts commit 8fa4c6c.
when response is a list of a single list of dict, it has to be handled separately
Collaborator
|
Thanks! Dropped the chat-template line since #72 already handles it. I collapsed the if/elif into a single [r[0] if isinstance(r, list) else r for r in response] and added a regression test in tests/llms/test_local_llm.py. |
mo374z
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73 the list handling
as well as the prompt template (Fixes #71)