Use consul.health.service()#13
Merged
geek merged 6 commits intoautopilotpattern:masterfrom Apr 6, 2017
Merged
Conversation
PyMongo -> 3.4.0 python-Consul -> 0.7.0
Don’t have `CONSUL_AGENT=1` implemented to make this optional so force localhost
Departure from consul.agent.services(). Fixes autopilotpattern#12
geek
reviewed
Apr 6, 2017
| from pymongo.errors import * | ||
|
|
||
| consul = pyconsul.Consul(host=os.environ.get('CONSUL', 'consul')) | ||
| consul = pyconsul.Consul(host='localhost') |
Contributor
There was a problem hiding this comment.
We will likely need to make the consul agent optional in the future, can you revert this change.
Contributor
|
@sberryman LTGM, just one question on manage.py |
Contributor
Author
|
@geek I've added |
Contributor
|
@sberryman thanks for the help, I'll get this released shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
Also upgrade python dependencies and containerpilot to 2.7.2