Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change tracking param #1161

Merged
merged 1 commit into from
Jun 24, 2022
Merged

feat: change tracking param #1161

merged 1 commit into from
Jun 24, 2022

Conversation

yukkysaito
Copy link
Contributor

@yukkysaito yukkysaito commented Jun 23, 2022 •
edited
Loading

Signed-off-by: Yukihiro Saito yukky.saito@gmail.com

Description

change data association param for large vehicle.
before
Peek 2022-06-23 19-32

after
Peek 2022-06-23 19-30

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yukkysaito
feat: change tracking param
a9506d2 
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@yukkysaito yukkysaito mentioned this pull request Jun 23, 2022
Merged
8 tasks
@codecov
Copy link

codecov bot commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #1161 (a9506d2) into main (a8e2308) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1161   +/-   ##
=====================================
  Coverage   9.12%   9.12%           
=====================================
  Files       1034    1034           
  Lines      70634   70634           
  Branches   14757   14757           
=====================================
  Hits        6444    6444           
  Misses     58903   58903           
  Partials    5287    5287
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 9.10% <ø> (ø) Carriedforward from a8e2308

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed66cb...a9506d2. Read the comment docs.

miursh
miursh approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito merged commit d345e91 into autowarefoundation:main Jun 24, 2022
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jun 25, 2022
Merged
yukkysaito added a commit to yukkysaito/autoware.universe that referenced this pull request Jun 29, 2022
@YoheiMishina @mitsudome-r
@kmiya @nnmm @TakaHoribe @nik-tier4 @wep21 @yukkysaito @tkimura4 @kenji-miyake @h-ohta @IshitaTakeshi @KeisukeShima @takayuki5168 @1222-takeshi
feat: add shape estimation package (autowarefoundation#100)
bd4111f 
* release v0.4.0

* fix uninitialized variables (autowarefoundation#816)

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 3a695e62c841e01681880263bb62a810f11ebf74.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

* port shape_estimation to ros2 (autowarefoundation#37)

* port shape_estimation to ros2

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* minor fix from review

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove unused files

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* minor fix on include

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix cmakelist

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove unused codes

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix cmake

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [shape_estimation] fix launch file (autowarefoundation#116)

* [shape_estimation] fix launch file

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* remove unnecessary find_package from CMakeLists.txt

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* adding linters to shape_estimation (autowarefoundation#174)

* Ros2 v0.8.0 shape estimation (autowarefoundation#257)

* fix typos in perception (autowarefoundation#862)

* Feature/camera lidar perception (autowarefoundation#937)

* add object splitter

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add object merger

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change pkg name

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add comment

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* remove litter

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* bug fix : debug code

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* enable vehicle to unknown track

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* bug fix

* add object position in clustering

* 🚮

* change param

* fix name

* bug fix

* add install

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug (autowarefoundation#1161) (autowarefoundation#374)

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Fix typo in perception module (autowarefoundation#440)

* add use_sim-time option (autowarefoundation#454)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Perception components (autowarefoundation#1368)

* [bev_optical_flow]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [object_merger]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [object_range_splitter]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [shape_estimation]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [map_based_prediction]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [naive_path_prediction]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [roi_image_saver]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [lidar_apollo_instance_segmentation]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [object_flow_fusion]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [traffic_light_map_based_detector]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [dynamic_object_visualization]: component node

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix typo

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* suppress warnings for shape estimation (autowarefoundation#1770)

* add Werror

* fix uninitialized

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Refactor shape estimation for detection by tracking (autowarefoundation#1861)

* refactor

* modification due to refactoring

* cosmetic change and add virtual

* change to lib

* fix typo

* bug fix

* cosmetic change

* bug fix

* add constexpr

* cosmetic change

* cosmetic change

* cosmetic change

* cosmetic change

* Invoke code formatter at pre-commit (autowarefoundation#1935)

* Run ament_uncrustify at pre-commit

* Reformat existing files
* Fix copyright and cpplint errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* add createQuaternionFromYaw (autowarefoundation#2120)

* add createQuaternionFromYaw

* add test

* change return value type of createQuaternionFromRPY from tf2::quat to geomety_msgs::msg::quat

* use geometry_msgs::msg::Quaternion in createQuaternionFromRPY in application

* Detection by tracker (autowarefoundation#1910)

* initial commit

* backup

* apply format

* cosmetic change

* implement divided under segmenterd clusters

* cosmetic change

* bug fix

* bug fix

* bug fix

* modify launch

* add debug and bug fix

* bug fix

* bug fix

* add no found tracked object

* modify parameters and cmake

* bug fix

* remove debug info

* add readme

* modify clustering launch

* run pre-commit

* cosmetic change

* cosmetic change

* cosmetic change

* apply markdownlint

* modify launch

* modify for cpplint

* modify qos

* change int to size_T

* bug fix

* change perception qos

* Update perception/object_recognition/detection/detection_by_tracker/package.xml

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* cosmetic change

* cosmetic change

* fix launch

* Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* modify header include order

* change include order

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* change to std::optional

* cosmetic change

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* bug fix

* modify readme

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Port shape estimation to .auto (autowarefoundation#551)

* Port shape estimation to .auto

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Cosmetic change

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Cosmetic change

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Run pre commit

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix typo

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Cosmetic change: type -> label

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add trailer label

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update document for shape estimation (autowarefoundation#604)

* Update document for shape estimation

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update perception/object_recognition/detection/shape_estimation/README.md

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Run pre-commit

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Address review

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* [shape_estimation]change type (autowarefoundation#663)

* change output type of shape_estimation

* remove unused function

* add dynamic_object_converter

* rename

* fix typo

* fix dummy_perception_publisher

* update readme

* fix copyright

* rename package

* add readme

* fix launch name

* remove unused variable

* fix readme

* fix convert function

* change topic name of DynamicObjectsWithFeature

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Takeshi Ishita <ishitah.takeshi@gmail.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
takayuki5168 referenced this pull request in tier4/autoware.universe Jul 4, 2022
@yukkysaito @takayuki5168
feat: change tracking param (#1161)
5dc1c9f 
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
takayuki5168 referenced this pull request in tier4/autoware.universe Jul 8, 2022
@yukkysaito @takayuki5168
feat: change tracking param (#1161)
e66ccfc 
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@yukkysaito @boyali
feat: change tracking param (tier4#1161)
8b7cead 
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@yukkysaito @boyali
feat: change tracking param (tier4#1161)
921a67b 
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@yukkysaito @boyali
feat: change tracking param (tier4#1161)
e18f2f5 
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@yukkysaito @boyali
feat: change tracking param (tier4#1161)
a43056b 
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miursh miursh miursh approved these changes

@aohsato aohsato Awaiting requested review from aohsato

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yukkysaito @miursh