This repository was archived by the owner on Mar 28, 2025. It is now read-only.
feat(sample_sensor_kit_launch): add param file for dummy_diag_publisher #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: asana17 <akihiro.sakurai@tier4.jp>
asana17
changed the title
7 tasks
Signed-off-by: asana17 <akihiro.sakurai@tier4.jp>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: asana17 akihiro.sakurai@tier4.jp
Description
The node dummy_diag_publisher is modified in autowarefoundation/autoware_universe#2840. I modified awf:autoware.universe/launch/tier4_system_launch/system.launch.xml because this node needs some parameter YAML files to launch. For this reason, we also need to add some param files to awf:autoware_launch and awf:sample_sensor_kit_launch, corresponding to the change above. Temporarily, I placed an empty parameter YAML file.
For more information, please look at the links below.
autowarefoundation/autoware_universe#2840
autowarefoundation/autoware_universe#2840 (review)
autowarefoundation/autoware_launch#206
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.