Skip to content
This repository was archived by the owner on Mar 28, 2025. It is now read-only.

Conversation

@kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 19, 2024

Description

Enhance logging of nebula_node_container.

  • Add glog_component in nebula_node_container so that all the LiDAR preprocessing container will have glog enabled
  • Change logging configuration from "screen" to "both" so that the log will be written to the log file as well as terminal

Related: tier4/aip_launcher#199

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Copy link
Contributor Author

kminoda commented Jan 19, 2024

@knzo25 Hi, would you mind reviewing this PR?

Copy link
Contributor

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kminoda kminoda merged commit af0d32b into main Jan 29, 2024
@kminoda kminoda deleted the chore/enhance_logging branch January 29, 2024 04:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants