Skip to content
This repository was archived by the owner on Mar 28, 2025. It is now read-only.

Conversation

@KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Jan 19, 2024

Description

I removed gnss_frame arg.

gnns_poser refers to msg.header.frame_id instead of parameter gnss_frame.
Please see autowarefoundation/autoware_universe#6116

(The original reason why we can not pass gnss_frame as arg is autowarefoundation/autoware_universe#5140 )

TIER IV INTERNAL ANNOUNCEMENT LINK

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi changed the title fix(gnss): remove gnss_frame arg fix(gnss_launch): remove gnss_frame arg Jan 19, 2024
@KYabuuchi KYabuuchi requested a review from YamatoAndo January 22, 2024 01:06
@KYabuuchi KYabuuchi marked this pull request as ready for review January 22, 2024 01:07
@KYabuuchi KYabuuchi merged commit ec28886 into autowarefoundation:main Jan 22, 2024
@KYabuuchi KYabuuchi deleted the fix/gnss_poser_frame_refers_msg_header branch January 22, 2024 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants