Conversation
Agent-Logs-Url: https://github.com/genevera/harbor/sessions/926d69c8-994a-4ec5-869b-2ad5bb9c3d05 Co-authored-by: genevera <12733137+genevera@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes Harbor’s special handling and documentation for the deprecated VLLM_ATTENTION_BACKEND setting, aligning Harbor’s vLLM integration with vLLM’s current behavior.
Changes:
- Stop passing
VLLM_ATTENTION_BACKENDinto the vLLM compose service. - Remove the default profile value for
HARBOR_VLLM_ATTENTION_BACKEND. - Remove the
harbor vllm attentionsubcommand and its CLI reference/user guide mentions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/compose.vllm.yml | Removes VLLM_ATTENTION_BACKEND from the vLLM container environment. |
| profiles/default.env | Drops HARBOR_VLLM_ATTENTION_BACKEND from the default profile. |
| harbor.sh | Removes the vllm attention CLI subcommand and help text. |
| docs/3.-Harbor-CLI-Reference.md | Deletes the CLI reference section for harbor vllm attention. |
| docs/1.-Harbor-User-Guide.md | Removes VLLM_ATTENTION_BACKEND from example config ls output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Solves #229 |
Agent-Logs-Url: https://github.com/genevera/harbor/sessions/a4b8e082-4f2d-4162-9d92-72a1ce0f18ad Co-authored-by: genevera <12733137+genevera@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent-Logs-Url: https://github.com/genevera/harbor/sessions/926d69c8-994a-4ec5-869b-2ad5bb9c3d05
VLLM_ATTENTION_BACKEND was deprecated in v0.13.0 - it is ignored now when starting VLLM so there's no reason for it to be still treated as something special by harbor