Skip to content

Remove deprecated VLLM_ATTENTION_BACKEND env var and docs#228

Merged
av merged 2 commits intoav:mainfrom
genevera:copilot/remove-deprecated-env-var-vllm-attention-backend
Apr 9, 2026
Merged

Remove deprecated VLLM_ATTENTION_BACKEND env var and docs#228
av merged 2 commits intoav:mainfrom
genevera:copilot/remove-deprecated-env-var-vllm-attention-backend

Conversation

@genevera
Copy link
Copy Markdown
Contributor

@genevera genevera commented Apr 7, 2026

Agent-Logs-Url: https://github.com/genevera/harbor/sessions/926d69c8-994a-4ec5-869b-2ad5bb9c3d05

VLLM_ATTENTION_BACKEND was deprecated in v0.13.0 - it is ignored now when starting VLLM so there's no reason for it to be still treated as something special by harbor

Copilot AI review requested due to automatic review settings April 7, 2026 21:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes Harbor’s special handling and documentation for the deprecated VLLM_ATTENTION_BACKEND setting, aligning Harbor’s vLLM integration with vLLM’s current behavior.

Changes:

  • Stop passing VLLM_ATTENTION_BACKEND into the vLLM compose service.
  • Remove the default profile value for HARBOR_VLLM_ATTENTION_BACKEND.
  • Remove the harbor vllm attention subcommand and its CLI reference/user guide mentions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
services/compose.vllm.yml Removes VLLM_ATTENTION_BACKEND from the vLLM container environment.
profiles/default.env Drops HARBOR_VLLM_ATTENTION_BACKEND from the default profile.
harbor.sh Removes the vllm attention CLI subcommand and help text.
docs/3.-Harbor-CLI-Reference.md Deletes the CLI reference section for harbor vllm attention.
docs/1.-Harbor-User-Guide.md Removes VLLM_ATTENTION_BACKEND from example config ls output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@genevera
Copy link
Copy Markdown
Contributor Author

genevera commented Apr 7, 2026

Solves #229

Copy link
Copy Markdown
Owner

@av av left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@av av merged commit bac2b19 into av:main Apr 9, 2026
@genevera genevera deleted the copilot/remove-deprecated-env-var-vllm-attention-backend branch April 10, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants