Remove Lazy Initialize on Benchlist #1423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Blocked on #1384 |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
alarso16
pushed a commit
that referenced
this pull request
Nov 24, 2025
maru-ava
added a commit
that referenced
this pull request
Dec 3, 2025
The ffi-nix test fails intermittently with differing symbol counts (e.g., 20534 vs 20535) but doesn't indicate which symbol differs, making root cause analysis difficult. ## Changes - Extract symbols to temp files and use `diff` to show which symbols are unique to each build when counts mismatch - Preserves existing behavior—only adds diagnostic output on failure - Added clarifying comments explaining the diff format options **Before:** ```bash Nix build: 20534 symbols Cargo build: 20535 symbols ❌ Symbol counts differ ``` **After:** ```bash Nix build: 20534 symbols Cargo build: 20535 symbols ❌ Symbol counts differ === Symbol Differences === Symbols only in Nix build: [symbol list] Symbols only in Cargo build: [symbol list] ``` ## Testing - ✅ Verified bash syntax is valid - ✅ Tested diff logic with various scenarios - ✅ No new shellcheck warnings introduced - ✅ Maintains backward compatibility - ✅ CI validated the changes and successfully identified the symbol causing the flakiness (`rtree_read.constprop.0`) - Fixes #1422 <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>ffi-nix test is flaky</issue_title> > <issue_description>See https://github.com/ava-labs/firewood/actions/runs/19077399006/job/54496653989 for an example. Earliest known failure is Oct 24.</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@rkuris</author><body> > @maru-ava reports it is not reproducible outside of CI. It may be x86 only.</body></comment_new> > <comment_new><author>@rkuris</author><body> > The biggest clue is that the number of symbols is different: > ``` > + echo 'Nix build: 20534 symbols' > Nix build: 20534 symbols > + echo 'Cargo build: 20535 symbols' > Cargo build: 20535 symbols > + '[' 20534 -eq 20535 ']' > ``` > > @copilot can you change the failing script so that it outputs the symbol differences?</body></comment_new> > </comments> > </details> - Fixes ava-labs/firewood#1422 <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rkuris <3193068+rkuris@users.noreply.github.com> Co-authored-by: maru <maru.newby@avalabs.org>
JonathanOppenheimer
pushed a commit
that referenced
this pull request
Dec 3, 2025
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
JonathanOppenheimer
added a commit
that referenced
this pull request
Dec 4, 2025
Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested