-
Notifications
You must be signed in to change notification settings - Fork 837
e2e: Run separate e2e jobs for mainnet and fuji rulesets
#2666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a7cc3d to
298793a
Compare
| TestMainnetID uint32 = 808 | ||
| TestFujiID uint32 = 909 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably add naming for these new networks and mapping networkIDs <-> networkName, simiarl to other networks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is being able to map the ids to names desirable if we're only ever intending to use the new ids for configuring rulesets for e2e testing?
abi87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should keep the e2e tests green even in case of deferred fork activation across networks (testnet, fuji, mainnet).
I would only fix the mapping of networkID <--> networkName.
Also we'll need to explicitly handle at least Durango fork in every e2e test. Should this be done in this PR?
Since e2e tests are already Durango compatible, maybe this PR can wait until Durango is activated on both Fuji and Mainnet to enable the new jobs? At that point any e2e changes required to support E will have to be backwards compatible to ensure the new jobs will continue to pass. |
298793a to
923db68
Compare
923db68 to
9ee5291
Compare
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
@StephenButtolph will be proposing a different approach so this PR is no longer needed. |
Co-authored-by: Chloe <99216251+coffeeavax@users.noreply.github.com>
The existing e2e job tests against network configured with a local ruleset. To ensure coverage that is more representative, this PR adds new jobs for running the e2e suite against each of the mainnet and fuji rulesets.
TODO
Startparameter required by pre-Durango rulesets.