Skip to content

Conversation

@marun
Copy link
Contributor

@marun marun commented Jan 24, 2024

The existing e2e job tests against network configured with a local ruleset. To ensure coverage that is more representative, this PR adds new jobs for running the e2e suite against each of the mainnet and fuji rulesets.

TODO

  • Figure out whether to update the tests for pre-Durango compatibility. The e2e tests were recently updated to be Durango-only which mainly means that validator and delegator addition no longer provides the Start parameter required by pre-Durango rulesets.
  • Update required jobs post-merge

@marun marun added the testing This primarily focuses on testing label Jan 24, 2024
@marun marun self-assigned this Jan 24, 2024
@marun marun linked an issue Jan 24, 2024 that may be closed by this pull request
@marun marun force-pushed the e2e-mainnet-fuji-rulesets branch from 6a7cc3d to 298793a Compare January 24, 2024 21:53
Comment on lines +29 to +30
TestMainnetID uint32 = 808
TestFujiID uint32 = 909
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably add naming for these new networks and mapping networkIDs <-> networkName, simiarl to other networks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is being able to map the ids to names desirable if we're only ever intending to use the new ids for configuring rulesets for e2e testing?

Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should keep the e2e tests green even in case of deferred fork activation across networks (testnet, fuji, mainnet).
I would only fix the mapping of networkID <--> networkName.
Also we'll need to explicitly handle at least Durango fork in every e2e test. Should this be done in this PR?

@marun
Copy link
Contributor Author

marun commented Jan 25, 2024

I agree we should keep the e2e tests green even in case of deferred fork activation across networks (testnet, fuji, mainnet). I would only fix the mapping of networkID <--> networkName. Also we'll need to explicitly handle at least Durango fork in every e2e test. Should this be done in this PR?

Since e2e tests are already Durango compatible, maybe this PR can wait until Durango is activated on both Fuji and Mainnet to enable the new jobs? At that point any e2e changes required to support E will have to be backwards compatible to ensure the new jobs will continue to pass.

@marun marun force-pushed the e2e-mainnet-fuji-rulesets branch from 298793a to 923db68 Compare January 26, 2024 18:22
@marun marun force-pushed the e2e-mainnet-fuji-rulesets branch from 923db68 to 9ee5291 Compare January 26, 2024 18:48
@github-actions
Copy link

github-actions bot commented Mar 3, 2024

This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

@marun
Copy link
Contributor Author

marun commented Jul 16, 2024

@StephenButtolph will be proposing a different approach so this PR is no longer needed.

@marun marun closed this Jul 16, 2024
@StephenButtolph StephenButtolph deleted the e2e-mainnet-fuji-rulesets branch July 24, 2024 20:52
chand1012 pushed a commit to multisig-labs/avalanchego that referenced this pull request Oct 1, 2024
Co-authored-by: Chloe <99216251+coffeeavax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/frozen testing This primarily focuses on testing

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

e2e: Add separate jobs for each of fuji and mainnet configuration

4 participants