chore: task reexecution #4443
chore: task reexecution #4443
Conversation
Elvis339
requested review from
aaronbuchwald,
joshua-kim and
maru-ava
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the C-Chain re-execution benchmark infrastructure to use externalized configuration and a custom GitHub action that doesn't rely on relative imports. The changes streamline task configuration by moving runtime variables to environment-based configuration and introduce predefined task configurations for common benchmark scenarios.
- Externalized runtime variables to environment configuration rather than explicit task parameters
- Added custom GitHub action for C-Chain re-execution benchmarks with improved dependency management
- Created predefined task configurations for common benchmark scenarios (hashdb, firewood, different block ranges)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/copy_dir.sh | Enhanced to support S3 object key expansion for simplified source specification |
| scripts/benchmark_cchain_range.sh | Added default values for optional variables and improved environment variable documentation |
| Taskfile.yml | Refactored task configuration to use externalized variables and added predefined benchmark tasks |
| .github/actions/run-monitored-tmpnet-cmd/output-metrics-url.sh | Added warning comment about file duplication |
| .github/actions/c-chain-reexecution-benchmark/output-metrics-url.sh | New duplicate of metrics URL generation script |
| .github/actions/c-chain-reexecution-benchmark/action.yml | New custom GitHub action for C-Chain re-execution benchmarks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/actions/c-chain-reexecution-benchmark/output-metrics-url.sh
Outdated
Show resolved
Hide resolved
…esolving error on compare benchmark results job
- inline set task env - remove unrelated `TMPNET_START_METRICS_COLLECTOR` env var
revert runner preset: - container - native
…eters and improve matrix handling
…hat wasnt installing Nix dependencies on self-hosted runners
…pdate workflow filename references
|
It seems the task described in the README to test Firewood fails: https://github.com/ava-labs/avalanchego/actions/runs/19719001624/job/56497689011#step:4:899 This may be a result of a faulty current state db pushed to the s3 bucket for Firewood. Since Firewood re-execution tests are not currently reliable due to https://github.com/ava-labs/coreth/issues/1158, it may be better to update the README to use a hashdb example that passes, but don't think that needs to block this PR. |
Why this should be merged
This patch is breakdown of #4435
This patch contains a custom action that doesn't rely on relative imports, workflows that externalize reexecute configuration to tasks.