Skip to content

Conversation

@ARR4N
Copy link
Collaborator

@ARR4N ARR4N commented Feb 14, 2025

Why this should be merged

Branch-protection rules only require the Go linter (erroneously called lint) by mistake. All linters are now dependencies of a single lint job that remains as a PR gate. New linters will now be enforced by default.

Closes #138

How this works

GitHub Actions need configuration. The path limitation of running yamllint is removed because it's such a cheap job so is ok to always run.

How this was tested

Inspection of CI run and PR's required jobs:

image

image

@ARR4N ARR4N marked this pull request as ready for review February 14, 2025 16:27
@ARR4N ARR4N requested review from a team, ceyonur, darioush and qdm12 and removed request for a team February 14, 2025 16:28
@ARR4N ARR4N enabled auto-merge (squash) February 14, 2025 16:29
Copy link

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ARR4N ARR4N merged commit bc42e5f into main Feb 14, 2025
11 checks passed
@ARR4N ARR4N deleted the arr4n/consolidate-linters branch February 14, 2025 16:48
ARR4N added a commit that referenced this pull request Feb 14, 2025
## Why this should be merged

New jobs are easily forgotten in the GitHub rules so we will only gate
on `go` and have all others added as dependencies.

## How this works

Same as #139 

## How this was tested

Inspection of CI run:

![image](https://github.com/user-attachments/assets/f76ce720-a5ed-49e6-b000-265f3660ce8f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): consolidate linting jobs

2 participants