Skip to content

Remove *Test.sol contracts for precompile testing #1915

@JonathanOppenheimer

Description

@JonathanOppenheimer

Following up on https://github.com/ava-labs/subnet-evm/pull/1913/files#r2603843811...

It's outside the scope of this PR, but could the ...Test.sol contracts be removed all together in the future (not a priority currently either way)? I think all we need to have the tests invoke the precompile directly via transactions are the ABI bindings for the precompile interface definitions, and the precompile interfaces and implementations themselves are what we are trying to test here; the wrapper contracts as they exist currently just add an additional thin and likely unnecessary layer to do so.

Originally posted by @michaelkaplan13 in #1913 (review)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions