chore: fix shellcheck directives #1905
Open
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
ceyonur
reviewed
Dec 5, 2025
|
|
||
| # Build Subnet EVM, which is run as a subprocess | ||
| echo "Building Subnet EVM @ GitCommit: $SUBNET_EVM_COMMIT at $BINARY_PATH" | ||
| # shellcheck disable=SC2153 # STATIC_LD_FLAGS is defined in constants.sh |
Collaborator
There was a problem hiding this comment.
are we sure that these are needed? I don't see anything on the avalanchego/coreth side for these changes? Could it be your local using a different shellcheck version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
These failures broke
./scripts/shellcheck.sh, which was not caught in this repository's CI for some reason. This PR adds the correct directives.How this was tested
Locally (CI doesn't catch)
Need to be documented?
No
Need to update RELEASES.md?
No