Base the line number off of the lines list length #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than having a separate variable that keeps track of the number of lines, use a property that returns the length of the list of lines. This also allows us to set line numbers as strings, which is allowed through the Avatax API. This also fixes a bug, where if functions using the line_num variable are called before the `with_line` function a TypeError is raised. This was due to the line_num variable not being instantiated until after the first time the `with_line` function is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @contygm I found an issue while developing against avalra with this sdk.
Rather than having a separate variable that keeps track of the number of lines,
use a property that returns the length of the list of lines. This also allows
us to set line numbers as strings, which is allowed through the Avatax API.
This also fixes a bug, where if functions using the line_num variable are called
before the
with_linefunction a TypeError is raised. This was due to theline_num variable not being instantiated until after the first time the
with_linefunction is called.