Multiple configs

[awirb]

If using different modules in a new function:

• in the ini file for this function, add a section called modName_override for each module
• configurations for these modules will be created using the (local if defaultConfig=False) default configuration and overriding the parameters from the modName_override section
• in the end, a function_settings.ini is saved to the outputs folder of the function: all the other parameters, which were not part of the override parameters, are added in the override sections for easy reproduction - only if addModValues = True

[pep8speaks]

Hello @awirb! Thanks for updating this PR.

• In the file avaframe/com3Hybrid/com3Hybrid.py:

Line 146:121: E501 line too long (130 > 120 characters)
Line 117:121: E501 line too long (126 > 120 characters)
Line 102:121: E501 line too long (125 > 120 characters)
Line 65:121: E501 line too long (128 > 120 characters)
Line 63:25: E225 missing whitespace around operator
Line 60:121: E501 line too long (125 > 120 characters)

• In the file avaframe/in3Utils/cfgHandling.py:

Line 413:121: E501 line too long (132 > 120 characters)
Line 363:42: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 360:42: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 85:71: E127 continuation line over-indented for visual indent

• In the file avaframe/in3Utils/cfgUtils.py:

Line 545:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

• In the file avaframe/tests/test_cfgHandling.py:

Line 174:121: E501 line too long (149 > 120 characters)
Line 166:121: E501 line too long (121 > 120 characters)
Line 163:5: E303 too many blank lines (2)
Line 143:121: E501 line too long (146 > 120 characters)
Line 136:121: E501 line too long (121 > 120 characters)
Line 24:51: E231 missing whitespace after ','
Line 22:51: E231 missing whitespace after ','

• In the file avaframe/tests/test_com1DFA.py:

Line 1631:9: E122 continuation line missing indentation or outdented
Line 1451:5: E303 too many blank lines (2)
Line 1446:50: E225 missing whitespace around operator
Line 1446:38: E225 missing whitespace around operator
Line 1406:43: E241 multiple spaces after ','
Line 1398:5: E303 too many blank lines (2)
Line 1331:121: E501 line too long (123 > 120 characters)
Line 1013:20: E231 missing whitespace after ','
Line 918:121: E501 line too long (123 > 120 characters)
Line 917:121: E501 line too long (123 > 120 characters)
Line 916:121: E501 line too long (123 > 120 characters)
Line 344:121: E501 line too long (127 > 120 characters)
Line 208:121: E501 line too long (127 > 120 characters)
Line 208:92: E231 missing whitespace after ','
Line 208:5: E303 too many blank lines (2)
Line 130:121: E501 line too long (132 > 120 characters)
Line 120:121: E501 line too long (153 > 120 characters)
Line 79:5: E303 too many blank lines (2)

Comment last updated at 2022-07-11 10:15:37 UTC

[codecov]

Codecov Report

Merging #740 (0f4a127) into master (ed0f19c) will decrease coverage by 0.05%.
The diff coverage is 53.03%.

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   75.54%   75.49%   -0.06%     
==========================================
  Files          56       56              
  Lines       11381    11427      +46     
==========================================
+ Hits         8598     8627      +29     
- Misses       2783     2800      +17     

Impacted Files	Coverage Δ
avaframe/com3Hybrid/com3Hybrid.py	0.00% <0.00%> (ø)
avaframe/in3Utils/cfgUtils.py	86.95% <53.84%> (-0.60%)	⬇️
avaframe/in3Utils/cfgHandling.py	85.71% <100.00%> (+3.10%)	⬆️
avaframe/in3Utils/initialiseDirs.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0f19c...0f4a127. Read the comment docs.

[matthiasto]

Sorry for the many comments... most of them are related to the hybrid script itself, so to my bad work ;)

[qlty-cloud-legacy]

Code Climate has analyzed commit 0f4a127 and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	3
Duplication	4

The test coverage on the diff in this pull request is 53.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.2% (0.0% change).

View more on Code Climate.