Skip to content

Conversation

@matthiasto
Copy link
Contributor

@matthiasto matthiasto commented Aug 18, 2022

Adds surface parallel coordinate computation to Aimec

@matthiasto matthiasto requested review from awirb and fso42 and removed request for fso42 August 18, 2022 06:34
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit d0a97fd and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.1%.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #751 (17dfa7e) into master (b7668ee) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   75.49%   74.95%   -0.54%     
==========================================
  Files          56       57       +1     
  Lines       11429    11628     +199     
==========================================
+ Hits         8628     8716      +88     
- Misses       2801     2912     +111     
Impacted Files Coverage Δ
avaframe/ana3AIMEC/aimecTools.py 82.23% <100.00%> (+0.37%) ⬆️
avaframe/log2Report/generateReport.py 82.90% <0.00%> (-4.98%) ⬇️
avaframe/in3Utils/geoTrans.py 93.26% <0.00%> (-2.97%) ⬇️
avaframe/com1DFA/DFAfunctionsCython.pyx 89.10% <0.00%> (-0.43%) ⬇️
avaframe/com1DFA/particleTools.py 53.41% <0.00%> (-0.30%) ⬇️
avaframe/ana1Tests/simiSolTest.py 83.33% <0.00%> (-0.10%) ⬇️
avaframe/out3Plot/outTopo.py 0.00% <0.00%> (ø)
avaframe/in2Trans/ascUtils.py 83.87% <0.00%> (ø)
avaframe/ana1Tests/rotationTest.py 0.00% <0.00%> (ø)
avaframe/out3Plot/plotUtils.py 94.29% <0.00%> (+0.01%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fso42 fso42 added the enhancement New feature or request label Aug 18, 2022
@fso42 fso42 added this to the Version 1.3 milestone Aug 18, 2022
@fso42 fso42 merged commit 01cbad3 into master Aug 22, 2022
@fso42 fso42 deleted the surfaceParallel branch August 22, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants