Prepare com1DFA code according to theory paper

[matthiasto]

This PR will update the code so that it matches the description in the theory paper.
I added com1DFA options:

• to add the curvature in the pressure gradient computation
• to add the curvature in the friction force
• to add the curvature in the tangential equation

The default settings should still produce the benchmarks results

[pep8speaks]

Hello @matthiasto! Thanks for updating this PR.

• In the file avaframe/ana1Tests/energyLineTest.py:

Line 213:121: E501 line too long (152 > 120 characters)
Line 203:22: W605 invalid escape sequence '\D'

• In the file avaframe/tests/test_DFAfunctionsCython.py:

Line 652:33: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 651:72: E225 missing whitespace around operator
Line 650:22: E225 missing whitespace around operator
Line 634:69: E225 missing whitespace around operator
Line 633:73: E225 missing whitespace around operator
Line 621:121: E501 line too long (144 > 120 characters)
Line 621:19: E127 continuation line over-indented for visual indent
Line 620:121: E501 line too long (129 > 120 characters)
Line 618:33: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 617:72: E225 missing whitespace around operator
Line 616:22: E225 missing whitespace around operator
Line 600:69: E225 missing whitespace around operator
Line 599:73: E225 missing whitespace around operator
Line 587:121: E501 line too long (144 > 120 characters)
Line 587:19: E127 continuation line over-indented for visual indent
Line 586:121: E501 line too long (129 > 120 characters)
Line 584:33: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 583:72: E225 missing whitespace around operator
Line 582:22: E225 missing whitespace around operator
Line 563:121: E501 line too long (144 > 120 characters)
Line 563:19: E127 continuation line over-indented for visual indent
Line 562:121: E501 line too long (129 > 120 characters)
Line 560:33: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 559:72: E225 missing whitespace around operator
Line 558:22: E225 missing whitespace around operator
Line 544:69: E225 missing whitespace around operator
Line 511:121: E501 line too long (144 > 120 characters)
Line 511:19: E127 continuation line over-indented for visual indent
Line 510:121: E501 line too long (129 > 120 characters)
Line 508:113: E202 whitespace before '}'
Line 507:43: E241 multiple spaces after ','
Line 506:91: E241 multiple spaces after ','
Line 505:121: E501 line too long (121 > 120 characters)
Line 264:121: E501 line too long (170 > 120 characters)
Line 242:121: E501 line too long (158 > 120 characters)

• In the file avaframe/tests/test_ana1Tests.py:

Line 202:121: E501 line too long (129 > 120 characters)
Line 199:121: E501 line too long (125 > 120 characters)
Line 198:121: E501 line too long (124 > 120 characters)

• In the file avaframe/tests/test_com1DFA.py:

Line 1414:43: E241 multiple spaces after ','
Line 1406:5: E303 too many blank lines (2)
Line 1020:20: E231 missing whitespace after ','
Line 120:121: E501 line too long (153 > 120 characters)
Line 79:5: E303 too many blank lines (2)

Comment last updated at 2022-09-01 11:20:21 UTC

[fso42]

To keep track: commit 419c11f introduced some changes to the benchmark results in regards to remeshing -> separate issue!

[qlty-cloud-legacy]

Code Climate has analyzed commit 08b04dd and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	2

The test coverage on the diff in this pull request is 86.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 72.7% (0.0% change).

View more on Code Climate.

[codecov]

Codecov Report

Merging #754 (08b04dd) into master (8a2c234) will decrease coverage by 0.07%.
The diff coverage is 86.70%.

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
- Coverage   74.99%   74.92%   -0.08%     
==========================================
  Files          57       57              
  Lines       11643    11673      +30     
==========================================
+ Hits         8732     8746      +14     
- Misses       2911     2927      +16     

Impacted Files	Coverage Δ
avaframe/ana1Tests/energyLineTest.py	97.72% <66.66%> (-0.51%)	⬇️
avaframe/com1DFA/DFAfunctionsCython.pyx	87.94% <87.42%> (-1.16%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.