Animate tt

[awirb]

create three panel plot of generation of tt-diagram

[pep8speaks]

Hello @awirb! Thanks for updating this PR.

• In the file avaframe/ana5Utils/distanceTimeAnalysis.py:

Line 254:9: E265 block comment should start with '# '
Line 253:9: E265 block comment should start with '# '
Line 252:9: E265 block comment should start with '# '
Line 249:5: E265 block comment should start with '# '
Line 241:5: E265 block comment should start with '# '
Line 168:121: E501 line too long (130 > 120 characters)

• In the file avaframe/com1DFA/com1DFA.py:

Line 2215:35: E127 continuation line over-indented for visual indent
Line 1375:121: E501 line too long (132 > 120 characters)
Line 184:121: E501 line too long (126 > 120 characters)

• In the file avaframe/out3Plot/outDistanceTimeAnalysis.py:

Line 658:38: E222 multiple spaces after operator
Line 655:33: E203 whitespace before ','
Line 640:10: E222 multiple spaces after operator
Line 635:5: E265 block comment should start with '# '
Line 607:28: E251 unexpected spaces around keyword / parameter equals
Line 607:26: E251 unexpected spaces around keyword / parameter equals
Line 606:79: E231 missing whitespace after ','
Line 606:74: E231 missing whitespace after ','
Line 606:71: E251 unexpected spaces around keyword / parameter equals
Line 606:69: E251 unexpected spaces around keyword / parameter equals
Line 576:5: E265 block comment should start with '# '
Line 564:13: E117 over-indented
Line 526:121: E501 line too long (141 > 120 characters)
Line 520:5: E265 block comment should start with '# '
Line 503:5: E265 block comment should start with '# '
Line 469:1: E303 too many blank lines (3)
Line 429:1: E303 too many blank lines (3)
Line 423:14: E261 at least two spaces before inline comment
Line 418:70: E231 missing whitespace after ','
Line 416:23: E222 multiple spaces after operator
Line 413:23: E222 multiple spaces after operator
Line 410:38: E261 at least two spaces before inline comment
Line 409:70: E231 missing whitespace after ','
Line 407:18: E261 at least two spaces before inline comment
Line 382:1: E302 expected 2 blank lines, found 1
Line 377:30: E261 at least two spaces before inline comment
Line 333:25: E225 missing whitespace around operator
Line 330:31: E261 at least two spaces before inline comment
Line 169:9: E222 multiple spaces after operator
Line 164:5: E265 block comment should start with '# '
Line 63:53: E222 multiple spaces after operator
Line 58:33: E203 whitespace before ','
Line 35:10: E222 multiple spaces after operator

• In the file avaframe/out3Plot/plotUtils.py:

Line 491:15: E711 comparison to None should be 'if cond is not None:'
Line 484:5: E303 too many blank lines (2)

• In the file avaframe/runScripts/runRangeTimeDiagram.py:

Line 121:121: E501 line too long (123 > 120 characters)
Line 117:21: E222 multiple spaces after operator
Line 85:42: E201 whitespace after '('
Line 71:121: E501 line too long (129 > 120 characters)
Line 27:1: E265 block comment should start with '# '
Line 24:1: E265 block comment should start with '# '

• In the file avaframe/runScripts/runThalwegTimeDiagram.py:

Line 112:121: E501 line too long (123 > 120 characters)
Line 109:21: E222 multiple spaces after operator
Line 67:121: E501 line too long (131 > 120 characters)
Line 25:1: E265 block comment should start with '# '
Line 22:1: E265 block comment should start with '# '

• In the file avaframe/tests/test_distanceTimeAnalysis.py:

Line 385:121: E501 line too long (172 > 120 characters)
Line 384:80: E231 missing whitespace after ','
Line 375:5: E303 too many blank lines (2)
Line 364:121: E501 line too long (153 > 120 characters)
Line 363:78: E231 missing whitespace after ','
Line 359:5: E303 too many blank lines (2)
Line 328:54: E231 missing whitespace after ','
Line 328:51: E231 missing whitespace after ','
Line 293:5: E265 block comment should start with '# '
Line 275:1: E303 too many blank lines (3)
Line 214:1: E302 expected 2 blank lines, found 1
Line 69:5: E303 too many blank lines (2)
Line 27:59: E231 missing whitespace after ','

• In the file avaframe/tests/test_fileHandlerUtils.py:

Line 248:5: E303 too many blank lines (2)

• In the file avaframe/tests/test_outDistanceTimeAnalysis.py:

Line 67:121: E501 line too long (147 > 120 characters)
Line 64:85: E231 missing whitespace after ','
Line 63:39: E225 missing whitespace around operator
Line 48:121: E501 line too long (123 > 120 characters)
Line 46:5: E303 too many blank lines (2)
Line 39:31: E231 missing whitespace after ','
Line 23:38: E225 missing whitespace around operator

• In the file avaframe/tests/test_plotUtils.py:

Line 205:61: E241 multiple spaces after ','
Line 205:57: E241 multiple spaces after ','
Line 205:49: E241 multiple spaces after ','
Line 205:45: E241 multiple spaces after ','
Line 198:121: E501 line too long (121 > 120 characters)
Line 182:121: E501 line too long (121 > 120 characters)
Line 171:121: E501 line too long (121 > 120 characters)
Line 149:23: E711 comparison to None should be 'if cond is None:'
Line 137:5: E303 too many blank lines (2)
Line 127:36: E231 missing whitespace after ','
Line 126:36: E231 missing whitespace after ','
Line 125:36: E231 missing whitespace after ','
Line 124:39: E231 missing whitespace after ','
Line 100:22: E711 comparison to None should be 'if cond is None:'
Line 99:22: E711 comparison to None should be 'if cond is None:'
Line 85:45: W291 trailing whitespace
Line 78:5: E303 too many blank lines (2)
Line 74:69: E221 multiple spaces before operator
Line 49:29: E231 missing whitespace after ','
Line 16:18: E231 missing whitespace after ','
Line 15:29: E231 missing whitespace after ','

Comment last updated at 2022-09-02 15:42:18 UTC

[codecov]

Codecov Report

Merging #755 (79d572b) into master (9f4c2a6) will increase coverage by 0.17%.
The diff coverage is 85.85%.

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   74.79%   74.97%   +0.17%     
==========================================
  Files          57       57              
  Lines       11828    12003     +175     
==========================================
+ Hits         8847     8999     +152     
- Misses       2981     3004      +23     

Impacted Files	Coverage Δ
avaframe/com1DFA/com1DFA.py	93.14% <25.00%> (-0.28%)	⬇️
avaframe/ana5Utils/distanceTimeAnalysis.py	82.53% <46.66%> (-4.69%)	⬇️
avaframe/out3Plot/outDistanceTimeAnalysis.py	81.87% <93.37%> (+8.29%)	⬆️
avaframe/out3Plot/plotUtils.py	94.42% <100.00%> (+0.13%)	⬆️
avaframe/in3Utils/fileHandlerUtils.py	85.94% <0.00%> (+1.30%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[matthiasto]

I guess we have the same issue with the commented section in the ini file...
Could we put some default values there for the avaParabola so it runs without having to provide all inputs?
I think the inputs for the animation need to be a bit more documented, it took me a little bt to understand the xmax and min etc...

[fso42]

• Please squash a few commits
• Does this PR conflict with #746 ?

[qlty-cloud-legacy]

Code Climate has analyzed commit 79d572b and detected 22 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	9
Duplication	13

The test coverage on the diff in this pull request is 85.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 72.8% (0.2% change).

View more on Code Climate.