Skip to content

Conversation

@awirb
Copy link
Contributor

@awirb awirb commented Aug 29, 2022

No description provided.

@awirb awirb requested a review from fso42 August 29, 2022 08:37
@pep8speaks
Copy link

Hello @awirb! Thanks for opening this PR.

Line 417:121: E501 line too long (132 > 120 characters)
Line 367:42: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 364:42: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 86:71: E127 continuation line over-indented for visual indent

Line 574:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Do see the Hitchhiker's guide to code style

@awirb awirb requested a review from matthiasto August 29, 2022 08:37
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 11140c4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 72.8% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #757 (11140c4) into master (55bf3e2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
+ Coverage   74.97%   74.98%   +0.01%     
==========================================
  Files          57       57              
  Lines       11631    11637       +6     
==========================================
+ Hits         8720     8726       +6     
  Misses       2911     2911              
Impacted Files Coverage Δ
avaframe/ana4Stats/probAna.py 85.84% <100.00%> (+0.13%) ⬆️
avaframe/in3Utils/cfgHandling.py 85.91% <100.00%> (+0.20%) ⬆️
avaframe/in3Utils/cfgUtils.py 88.12% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fso42 fso42 added the enhancement New feature or request label Aug 29, 2022
@fso42 fso42 added this to the Version 1.3 milestone Aug 29, 2022
@fso42
Copy link
Contributor

fso42 commented Aug 29, 2022

@awirb: Why not just use the simulation name?

Copy link
Contributor

@matthiasto matthiasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this scenario name say? can you give an example?

@awirb
Copy link
Contributor Author

awirb commented Aug 30, 2022

It can be used to gather multiple simulations for example if you do a probRun, and vary multiple variables one after the other, and you want to plot some result parameter vs the other and group the ones where parameter a was varied and those where parameter b was varied.

Copy link
Contributor

@fso42 fso42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe squash the commits to just one...

@fso42 fso42 merged commit 830a2c5 into master Aug 30, 2022
@fso42 fso42 deleted the scName branch August 30, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants