-
Notifications
You must be signed in to change notification settings - Fork 5
add scenario name to configuration that can be used for plotting example #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @awirb! Thanks for opening this PR.
Do see the Hitchhiker's guide to code style |
|
Code Climate has analyzed commit 11140c4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 72.8% (0.0% change). View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
==========================================
+ Coverage 74.97% 74.98% +0.01%
==========================================
Files 57 57
Lines 11631 11637 +6
==========================================
+ Hits 8720 8726 +6
Misses 2911 2911
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@awirb: Why not just use the simulation name? |
matthiasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this scenario name say? can you give an example?
|
It can be used to gather multiple simulations for example if you do a probRun, and vary multiple variables one after the other, and you want to plot some result parameter vs the other and group the ones where parameter a was varied and those where parameter b was varied. |
fso42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe squash the commits to just one...
No description provided.