Skip to content

Change cfg logic for com1DFA - #779

Merged
fso42 merged 3 commits into
masterfrom
changeCfgLog
Dec 7, 2022
Merged

Change cfg logic for com1DFA#779
fso42 merged 3 commits into
masterfrom
changeCfgLog

Conversation

@awirb

@awirb awirb commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

created new workflow:

  • com1DFAPreprocess
  • com1DFAMain
  • com1DFAPostprocess

@awirb
awirb requested review from fso42 and matthiasto November 7, 2022 06:37
@fso42 fso42 self-assigned this Nov 8, 2022
@fso42 fso42 added the enhancement New feature or request label Nov 8, 2022
@fso42 fso42 added this to the Version 1.4 milestone Nov 8, 2022
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/deriveParameterSet.py Outdated
Comment thread avaframe/in3Utils/cfgUtils.py
@codecov

codecov Bot commented Nov 24, 2022

Copy link
Copy Markdown

Codecov Report

Base: 75.37% // Head: 75.39% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (2c9adfb) compared to base (cc14e44).
Patch coverage: 93.15% of modified lines in pull request are covered.

❗ Current head 2c9adfb differs from pull request most recent head 7972438. Consider uploading reports for the commit 7972438 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   75.37%   75.39%   +0.02%     
==========================================
  Files          59       59              
  Lines       12583    12605      +22     
==========================================
+ Hits         9484     9504      +20     
- Misses       3099     3101       +2     
Impacted Files Coverage Δ
avaframe/com3Hybrid/com3Hybrid.py 0.00% <0.00%> (ø)
avaframe/com1DFA/com1DFA.py 92.89% <88.88%> (-0.26%) ⬇️
avaframe/com1DFA/deriveParameterSet.py 82.86% <90.47%> (+0.62%) ⬆️
avaframe/in1Data/getInput.py 97.66% <97.05%> (-1.71%) ⬇️
avaframe/in3Utils/cfgUtils.py 88.32% <97.91%> (+0.20%) ⬆️
avaframe/com1DFA/com1DFATools.py 100.00% <100.00%> (ø)
avaframe/out1Peak/outPlotAllPeak.py 98.23% <100.00%> (+0.03%) ⬆️
avaframe/ana3AIMEC/ana3AIMEC.py 85.18% <0.00%> (-1.60%) ⬇️
avaframe/com1DFA/DFAfunctionsCython.pyx 87.70% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread avaframe/com1DFA/com1DFA.py
Comment thread avaframe/in3Utils/cfgUtils.py Outdated
Comment thread avaframe/in3Utils/cfgUtils.py
Comment thread avaframe/in1Data/getInput.py
Comment thread avaframe/in3Utils/cfgUtils.py
@fso42

fso42 commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

Results of standardtests are ok

Comment thread avaframe/in3Utils/cfgUtils.py
Comment thread avaframe/in3Utils/cfgUtils.py Outdated
awirb and others added 3 commits December 7, 2022 15:46
	- add required import of configparser to check type
	- rename simDFOld, simNameOld to simDFExisting, simNameExisting
 	- add deepdiff and deepmerge dependency
@fso42 fso42 mentioned this pull request Dec 7, 2022
@fso42 fso42 linked an issue Dec 7, 2022 that may be closed by this pull request
@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit 7972438 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

The test coverage on the diff in this pull request is 91.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.4% (0.1% change).

View more on Code Climate.

@fso42
fso42 merged commit 3887702 into master Dec 7, 2022
@fso42
fso42 deleted the changeCfgLog branch December 7, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Override Section issue

3 participants