Skip to content

Fix approach velocity for rangeTimeDiagram; Issue #782 - #786

Merged
fso42 merged 1 commit into
masterfrom
fixAppVel
Nov 24, 2022
Merged

Fix approach velocity for rangeTimeDiagram; Issue #782#786
fso42 merged 1 commit into
masterfrom
fixAppVel

Conversation

@awirb

@awirb awirb commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

according to issue #782 there was a problem if the avalanche ran beyond the field of view of the radar and hence the line of sight distance was not existent, so now in this case it is set to nan which caused a problem for the current way of computing the approach velocity, as all the values after timewise the max runout occurred are removed, this requires to convert the distance to the radar into a distance measured from top towards the radar

@fso42 fso42 added the confirmed Something isn't working label Nov 23, 2022
@fso42 fso42 added this to the Version 1.4 milestone Nov 23, 2022
@fso42 fso42 linked an issue Nov 23, 2022 that may be closed by this pull request
@awirb
awirb requested a review from fso42 November 24, 2022 08:14
@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit 382d2eb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.3% (0.0% change).

View more on Code Climate.

@codecov

codecov Bot commented Nov 24, 2022

Copy link
Copy Markdown

Codecov Report

Base: 75.32% // Head: 75.34% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (382d2eb) compared to base (06135d1).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 382d2eb differs from pull request most recent head fb37f36. Consider uploading reports for the commit fb37f36 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   75.32%   75.34%   +0.02%     
==========================================
  Files          59       59              
  Lines       12555    12570      +15     
==========================================
+ Hits         9457     9471      +14     
- Misses       3098     3099       +1     
Impacted Files Coverage Δ
avaframe/ana5Utils/distanceTimeAnalysis.py 83.58% <100.00%> (+0.75%) ⬆️
avaframe/out3Plot/outAIMEC.py 84.72% <0.00%> (-0.15%) ⬇️
avaframe/ana3AIMEC/aimecTools.py 81.74% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fso42 fso42 changed the title Fix app vel Fix approach velocity for rangeTimeDiagram; Issue #782 Nov 24, 2022
@fso42 fso42 self-assigned this Nov 24, 2022
  - update pytest and change check of type so it also works for int
@fso42
fso42 merged commit 7cfdf8c into master Nov 24, 2022
@fso42
fso42 deleted the fixAppVel branch November 24, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

confirmed Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Range time diagram problem

3 participants