Glide snow tool - #790
Merged
Merged
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov ReportBase: 75.34% // Head: 75.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #790 +/- ##
==========================================
- Coverage 75.34% 75.17% -0.17%
==========================================
Files 59 59
Lines 12570 12929 +359
==========================================
+ Hits 9471 9720 +249
- Misses 3099 3209 +110
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
awirb
requested changes
Dec 12, 2022
matthiasto
force-pushed
the
glideSnowTool
branch
from
December 12, 2022 13:22
11e558f to
d0b1824
Compare
awirb
reviewed
Dec 12, 2022
fso42
requested changes
Dec 21, 2022
|
Code Climate has analyzed commit 05afaa2 and detected 8 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 73.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.2% (-0.2% change). View more on Code Climate. |
fso42
approved these changes
Dec 22, 2022
Contributor
|
Standard tests ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cohesion option in the DFA module
Add triangular initialization method
documentation available here : https://docs.avaframe.org/en/glidesnowtool/